Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config-presets): do not use custom endpoints when using github/gitlab presets directly #6022

Merged
merged 1 commit into from Apr 21, 2020
Merged

fix(config-presets): do not use custom endpoints when using github/gitlab presets directly #6022

merged 1 commit into from Apr 21, 2020

Conversation

fgreinacher
Copy link
Contributor

Fixes #6014
Supersedes #5973

@fgreinacher
Copy link
Contributor Author

The main change here is that the github/gitlab presets now export a dedicated method getPresetFromEndpoint that is only used by the local preset. When used directly (via the >github/>gitlab prefix the logic will go through getPreset, not looking at the config at all.

IMO this is the correct behavior and makes hoops like in #5973 unnecessary.

@fgreinacher
Copy link
Contributor Author

fgreinacher commented Apr 21, 2020 •
edited

Seems like coverage is missing somewhere. Is there simple way to find out where?

Found the report in the artifacts. Isn't this supposed to go to codecov.io?

@rarkins rarkins merged commit 9647ea7 into renovatebot:master Apr 21, 2020
@fgreinacher fgreinacher deleted the fix/gh-preset-endpoint branch April 21, 2020 13:46
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 19.216.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub-hosted Preset stopped loading
4 participants
@fgreinacher @renovate-release @viceice @rarkins