-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipenv): support dynamic python selection #6036
Conversation
Co-Authored-By: Rhys Arkins <rhys@arkins.net>
Should come from the Pipfile itself though? I would guess that if the Pipfile specifies it then it's in the lock, but otherwise not. |
I haven't found any |
Co-Authored-By: Rhys Arkins <rhys@arkins.net>
Waiting on renovatebot/docker-python#30 |
I'll fix this up |
Example: renovate-tests/deepbedmap#3 |
lib/manager/pipenv/artifacts.ts
Outdated
@@ -28,14 +54,20 @@ export async function updateArtifacts({ | |||
const localPipfileFileName = join(config.localDir, pipfileName); | |||
await outputFile(localPipfileFileName, newPipfileContent); | |||
const localLockFileName = join(config.localDir, lockFileName); | |||
const cmd = 'pipenv lock'; | |||
const cmd = ['pip install pipenv', 'pipenv --user lock']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this install pipenv even for users who are running with binarySource=auto?
@viceice perhaps we need to give user 1000 permissions on |
Will look at it |
@rarkins why not always install pipenv on run? So we don't need it in full image. I think pip will do nothing, if it's already installed. |
If people are running this in non-Docker I don't think we should be installing software. |
🎉 This PR is included in version 19.224.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
ref: renovatebot/docker-python#24, renovatebot/docker-pipenv#25
closes: #6035