Renovate not updating pubspec.lock

[rohansingh]

What Renovate type are you using?

Self-hosted, with --binary-source docker.

Describe the bug

Renovate is opening pull requests that update pubspec.yaml, but which do not update pubspec.lock with corresponding changes.

Did you see anything helpful in debug logs?

Nothing specific, but here is the generation of one PR, to upgrade the dependency flutter_typeahead:

Logs

DEBUG: processBranch with 1 upgrades (repository=tidbyt/tidbyt, dependencies=flutter_typeahead, branch=renovate/flutter_typeahead-1.x)
--
  | DEBUG: Setting baseBranch to master (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: latest commit (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | "branchName": "master",
  | "latestCommitDate": "2020-04-24 16:30:42 -0400"
  | DEBUG: getBranchPr(renovate/flutter_typeahead-1.x) (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: findPr(renovate/flutter_typeahead-1.x, undefined, open) (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: branchExists=false (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: Branch has been checked in master issue: unlimit (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: Branch has 1 upgrade(s) (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: recreateClosed is false (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: findPr(renovate/flutter_typeahead-1.x, fix(deps): update dependency flutter_typeahead to v1.8.0, !open) (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: prAlreadyExisted=false (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: Checking schedule(at any time, null) (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: No schedule defined (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: Branch needs creating (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: Using parentBranch: undefined (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: manager.getUpdatedPackageFiles() (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: Starting search at index 861 (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: Found match at index 861 (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: Contents updated (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: Updated 1 package files (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: Getting updated lock files (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: lock file dirs (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | "dirs": {
  | "yarnLockDirs": [],
  | "npmLockDirs": [],
  | "pnpmShrinkwrapDirs": [],
  | "lernaDirs": []
  | }
  | DEBUG: Writing package.json files (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | "packageFiles": ["package.json"]
  | DEBUG: Writing package-lock.json (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: Writing any updated package files (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: No updated lock files in branch (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: Checking for post-upgrade tasks (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | "tasks": {"commands": [], "fileFilters": []},
  | "allowedCommands": [".*"]
  | DEBUG: 1 file(s) to commit (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)
  | DEBUG: Committing files to branch renovate/flutter_typeahead-1.x (repository=tidbyt/tidbyt, branch=renovate/flutter_typeahead-1.x)

To Reproduce

This is a private monorepo but I'm happy to provide access temporarily if it helps with debugging.

Additional context

This is a monorepo with the Dart project living in the flutter/ directory, so the relevant files are flutter/pubspec.yaml and flutter/pubspec.lock. Perhaps this is similar to #2519?

blocked by

• add flutter-version datasource #12820
• add flutter tool containerbase/base#200

[rarkins]

Looks like we don't actually have pubspec.lock support yet. If you can set up a demo public repo and find any relevant links, it will help to getting this feature ready.

[viceice]

https://dart.dev/tools/pub/cmd/pub-upgrade

We need to run pub upgrade xyz for single update and pup upgrade to update all dep in pupspec.yml range.

@rarkins can you prepare docker-pub and maybe docker-dart repo or do we have it?

[rarkins]

Does it work if we’ve updated the yaml directly first? And can we add multiple package names in one command?

[viceice]

Yes, we only need docker-dart, pub is part of the sdk. pub upgrade simply ignores the lockfile and creates a new file with updates in range. It never touches the pubspec.yml.

it also supports multiple upgrades: pub upgrade xyz abc def

[viceice]

With dep name passed it only upgrades the dep and transitive deps (only the lockfile is updated)

[viceice]

buildpack and sidecar image prepared, this should now use our sidecar image with buildpack code

renovate/lib/util/exec/buildpack.ts

Line 14 in 16bd063

const allToolConfig: Record<string, ToolConfig> = {

renovate/lib/modules/manager/flux/artifacts.ts

Lines 25 to 35 in dca3418

	const execOptions: ExecOptions = {
	docker: {
	image: 'sidecar',
	},
	toolConstraints: [
	{
	toolName: 'flux',
	constraint: updatedDeps[0].newVersion,
	},
	],
	};

[renovate-release]

🎉 This issue has been resolved in version 34.73.0 🎉

The release is available on:

• GitHub release
• 34.73.0

Your semantic-release bot 📦🚀