feat(nvm): support .nvmrc files at any depth #6107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous regex only supported `.nvmrc` in the root directory. Now nvmrc at any directory depth is allowed. Actually, the previous regex didn't escape the `.`, so `anvmrc`, `bnvmrc`, etc. were also valid files 馃槄 Fixes #6106
rarkins
changed the title
|
Wow this is insanely fast. I just opened the issue 1 hr ago and already fixed on a Friday afternoon. |
:) |
|
Only thing is - if you're using the app then unfortunately you won't see it go live tonight, probably some time tomorrow. |
I need it live now. This is unacceptable. I demand a refund 馃槀馃槀 |
|
@esetnik It was a quick fix, and your issues was at the top 馃槃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous regex only supported
.nvmrcin the root directory. Now nvmrc at any directory depth is allowed.Actually, the previous regex didn't escape the
., soanvmrc,bnvmrc, etc. were also valid files 馃槄Fixes #6106