Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Better GraphQL snapshots #6128

Merged
merged 2 commits into from May 5, 2020

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented May 5, 2020

GraphQL snapshots are hard to compare between each other during refactoring, let's compare objects instead.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea!

@zharinov zharinov marked this pull request as draft May 5, 2020 12:08
@zharinov zharinov marked this pull request as ready for review May 5, 2020 12:09
@zharinov
Copy link
Collaborator Author

zharinov commented May 5, 2020

Some of them are failing to parse, but it's okay at this stage, I'll fix it in upcoming PR

@rarkins rarkins changed the title feat(http): Better GraphQL snapshots test: Better GraphQL snapshots May 5, 2020
@rarkins rarkins merged commit aa38ddf into renovatebot:master May 5, 2020
@rarkins rarkins deleted the feat/graphql-test-snapshots branch May 5, 2020 12:57
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 19.231.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants