refactor(gitlab): Use new http wrapper for Gitlab platform #6275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tlab-http-wrapper
|
Do we have good example repos to test against? |
|
Probably, I can just push my existing test repo to new Gitlab remote |
rarkins
requested changes
May 20, 2020
|
Seems to be working with test repo: https://gitlab.com/zharinov/renovate-test/-/merge_requests |
…tlab-http-wrapper
viceice
reviewed
May 23, 2020
Comment on lines
+1036
to
+1042
| { | ||
| iid: number; | ||
| source_branch: string; | ||
| title: string; | ||
| state: string; | ||
| created_at: string; | ||
| }[] |
There was a problem hiding this comment.
We sould extract a type for this
| @@ -686,7 +731,7 @@ export async function setBranchStatus({ | |||
|
|
|||
| export async function getIssueList(): Promise<any[]> { | |||
| if (!config.issueList) { | |||
| const res = await api.get( | |||
| const res = await gitlabApi.getJson<{ iid: number; title: string }[]>( | |||
There was a problem hiding this comment.
Create a type for this. maybe we should move all gitlab api types to ./types.ts
| const pr = (await api.get(url)).body; | ||
| const pr = ( | ||
| await gitlabApi.getJson< | ||
| Pr & { |
There was a problem hiding this comment.
We should have a helper function for mapping Pr to have proper types, see comments below
…tlab-http-wrapper # Conflicts: # lib/util/http/gitlab.spec.ts
…tlab-http-wrapper # Conflicts: # lib/platform/gitlab/gl-got-wrapper.ts
zharinov
force-pushed
the
feat/gitlab-http-wrapper
branch
from
241ce02
to
2153991
Compare
…tlab-http-wrapper # Conflicts: # lib/platform/gitlab/index.ts
zharinov
force-pushed
the
feat/gitlab-http-wrapper
branch
from
e2be44d
to
e7b9289
Compare
|
🎉 This PR is included in version 20.11.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #5865