feat(cache): redis global cache #6315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
requested changes
May 24, 2020
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
reviewed
May 24, 2020
viceice
reviewed
May 25, 2020
There was a problem hiding this comment.
I think we should change the redis libr to handy-redis.
It has better typescript support and recent releases.
I can do the switch.
rarkins
commented
May 25, 2020
|
|
||
| export function end(): void { | ||
| try { | ||
| client?.redis?.end(true); // TODO: Why is this not supported by client directly? |
There was a problem hiding this comment.
@viceice I wonder if I'm missing something here. Renovate wouldn't exit without the redis client being cleaned up, so I can't understand why it is not a first-class function in handy-redis.
There was a problem hiding this comment.
strange, client.quit() is there
viceice
approved these changes
May 25, 2020
viceice
reviewed
May 25, 2020
| @@ -85,6 +85,7 @@ export async function start(): Promise<0 | 1> { | |||
| await repositoryWorker.renovateRepository(repoConfig); | |||
| } | |||
| setMeta({}); | |||
| globalCache.cleanup(config); | |||
There was a problem hiding this comment.
Maybe we should call this in finally and use redis.quit instead of end
|
🎉 This PR is included in version 20.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds redis as an option for the global cache.
global.renovateCachewill be refactored later.