Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuget): refactor parallel release fetching #6331

Merged
merged 2 commits into from May 26, 2020
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented May 26, 2020

Refactors multiple registryUrls fetching in nuget datasource to perform concatenation manually and clone the result and releases.

Closes #6299

@rarkins rarkins requested a review from viceice May 26, 2020 19:51
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use a global set instead of searching the full array again in and again?

@rarkins
Copy link
Collaborator Author

rarkins commented May 26, 2020

I don't think performance is too much of a concern here.

@viceice
Copy link
Member

viceice commented May 26, 2020

Ok, can be done later

@rarkins rarkins merged commit 98d984a into master May 26, 2020
@rarkins rarkins deleted the fix/6299-nuget-fetch branch May 26, 2020 20:30
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 20.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renovate exits with 0 status and stops processing further repos
3 participants