Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitbucket server] emoji in PR is triggering 500 error in BB #6424

Closed
niorg opened this issue Jun 3, 2020 · 11 comments · Fixed by #9185
Closed

[bitbucket server] emoji in PR is triggering 500 error in BB #6424

niorg opened this issue Jun 3, 2020 · 11 comments · Fixed by #9185
Assignees
Labels
platform:bitbucket-server Bitbucket Data Center and Server platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:docs Documentation

Comments

@niorg
Copy link

niorg commented Jun 3, 2020

Running renovate 20.19.2 docker against bitbucket server 7.0.1 is getting error:

FATAL: Failed to update PR (repository=xx/xxx)
         ...
         "body": {
           "errors": [
             {
               "context": null,
               "message": "A database error has occurred.",
               "exceptionName": "com.atlassian.bitbucket.DataStoreException"
             }
           ]
         },
         "message": "Response code 500 (Internal Server Error)",
         "stack": "HTTPError: Response code 500 (Internal Server Error)\n    at EventEmitter.<anonymous> (/usr/src/app/node_modules/got/source/as-promise.js:74:19)\n    at runMicrotasks (<anonymous>)\n    at processTicksAndRejections (internal/process/task_queues.js:97:5)"
       }

bitbucket server is logging this:
o.h.e.jdbc.spi.SqlExceptionHelper Data truncation: Incorrect string value: '\xF0\x9F\x93\x85 *...' for column `stash`.`sta_pull_request`.`description` at row 1

Version 19.xx is running fine, changing unicodeEmoji to False in the renovate.json of the repository is not making a difference either.

@rarkins
Copy link
Collaborator

rarkins commented Jun 3, 2020

Which database are you using, and exactly how did you try to configure unicodeEmoji?

@niorg
Copy link
Author

niorg commented Jun 3, 2020

This is on MariaDB 10.3

I modified the renovate.json in one of the discovered repositories in the project like this:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "unicodeEmoji": false
}

But PR's on that repository still have this issue.

@rarkins
Copy link
Collaborator

rarkins commented Jun 3, 2020

You need to configure it in the bot and not repo

@niorg
Copy link
Author

niorg commented Jun 3, 2020

Ah yes, thank you, that seems to work. Wouldn't it make sense to make this the default for bitbucket server platform?

@rarkins
Copy link
Collaborator

rarkins commented Jun 3, 2020

There was some discussion in #3799 about it. The problem is specific to MySql/MariaDB, not Bitbucket Server itself.

Atlassian's documentation says "MySQL and MariaDB, while supported by Bitbucket Server, are currently not recommended"

@viceice
Copy link
Member

viceice commented Jun 4, 2020

Emojis are working fine on bitbucket server with mssql server. We use them since available.

@rarkins
Copy link
Collaborator

rarkins commented Jun 4, 2020

Let's add it to our self-hosted instructions for Bitbucket Server

@rarkins rarkins added type:docs Documentation platform:bitbucket-server Bitbucket Data Center and Server platform labels Jun 18, 2020
@ronaldploeger
Copy link

ronaldploeger commented Feb 9, 2021

Hi @rarkins,
Hi @niorg,

I am having the same problem with Bitbucket Server when Renovate tries to create the onboarding PR

Incorrect string value: '\xF0\x9F\x9A\xA6 T...' for column 'description' at row 1]

But I do not understand what you guys meant with "You need to configure it in the bot and not repo".

Can you please elaborate where I need to configure this or point me to the self-hosted instructions for Bitbucket Server where it has been documented.

Thank you!

@viceice
Copy link
Member

viceice commented Feb 9, 2021

@ronaldploeger Are you using MariaDB / MySQL for your Bitbucket server? see here: #3799 (comment)

Please checkout https://docs.renovatebot.com/configuration-options/#unicodeemoji for a workaround

@ronaldploeger
Copy link

@viceice Thank you.

I have now understood that I need to add this to my self-hosting RENOVATE_CONFIG_FILE, which now looks similar to this and it works like a charm:

module.exports = {
  endpoint: 'https://myBitbucketServer.com',
  platform: 'bitbucket-server',
  username: 'myUserName',
  unicodeEmoji: false,
  onboardingConfig: {
    extends: ['config:base'],
  }
}

@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-5-triage labels Mar 8, 2021
@HonkingGoose HonkingGoose self-assigned this Mar 8, 2021
@HonkingGoose HonkingGoose added status:in-progress Someone is working on implementation and removed status:ready labels Mar 17, 2021
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 24.89.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform:bitbucket-server Bitbucket Data Center and Server platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:docs Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants