feat(npm): call lerna directly instead of via npx #6434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: If installing renovate from npm, and also using lerna, then you now must install lerna prior to running renovate.
viceice
reviewed
Jun 4, 2020
|
Well, maybe someone depends on |
|
If you think I'm being too careful then we can remove the breaking part and release a minor |
|
🤔 as your issue suggests lerna is already broken since v20, so i think it is ok to release a minor to fix it. Maybe we need to global install latest lerna to full image now or before this merge? |
|
Yes, good idea to install Lerna for the full image |
viceice
approved these changes
Jun 4, 2020
|
Lerna is now installed to full image globally |
|
🎉 This PR is included in version 21.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6433
BREAKING CHANGE: If installing renovate from npm, and also using lerna, then you now must install lerna prior to running renovate.