Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove util/got #6522

Closed
rarkins opened this issue Jun 16, 2020 · 5 comments · Fixed by #6523
Closed

Remove util/got #6522

rarkins opened this issue Jun 16, 2020 · 5 comments · Fixed by #6523
Assignees
@zharinov
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jun 16, 2020 •
edited

This change:

image

Results in:

image
@rarkins
Copy link
Collaborator Author

rarkins commented Jun 16, 2020

Cc @viceice

@rarkins
Copy link
Collaborator Author

rarkins commented Jun 16, 2020

When I run yarn jest util/http it all passes though, but they fail when run as part of yarn jest.

@zharinov
Copy link
Collaborator

For some failed cases, it's something to do with retries on 4xx/5xx responses

@viceice
Copy link
Member

viceice commented Jun 16, 2020

Yes, can be the default got retry or some tests doing wrong mocking.

@viceice viceice added #internal type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels Jun 16, 2020
@zharinov zharinov mentioned this issue Jun 16, 2020
Merged
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 21.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zharinov zharinov

Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Remove 'util/got' zharinov/renovate
4 participants
@zharinov @viceice @rarkins @renovate-release