Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate crashes with Gitea if next pagination page is empty #6600

Closed
CirnoT opened this issue Jun 27, 2020 · 0 comments · Fixed by #6598
Closed

Renovate crashes with Gitea if next pagination page is empty #6600

CirnoT opened this issue Jun 27, 2020 · 0 comments · Fixed by #6598
Assignees
Labels
platform:gitea Gitea or Forgejo platforms priority-1-critical A bad bug or work that is holding up a lot of other important features or fixes type:bug Bug fix of existing functionality

Comments

@CirnoT
Copy link
Contributor

CirnoT commented Jun 27, 2020

What Renovate type are you using?

v21.18.3, self-hosted

Describe the bug

Renovate crashes with Gitea if next pagination page is empty

Did you see anything helpful in debug logs?

         {
           "name": "renovate",
           "level": 50,
           "logContext": "KVZYKAwSe",
           "repository": "***",
           "err": {
             "message": "pc.push is not iterable (cannot read property Symbol(Symbol.iterator))",
             "stack": "TypeError: pc.push is not iterable (cannot read property Symbol(Symbol.iterator))\n    at GiteaHttp.request (/usr/src/app/node_modules/renovate/dist/util/http/gitea.js:46:20)\n    at runMicrotasks (<anonymous>)\n    at processTicksAndRejections (internal/process/task_queues.js:97:5)\n    at async GiteaHttp.requestJson (/usr/src/app/node_modules/renovate/dist/util/http/index.js:135:21)\n    at async Object.searchIssues (/usr/src/app/node_modules/renovate/dist/platform/gitea/gitea-helper.js:145:17)\n    at async Proxy.ensureIssueClosing (/usr/src/app/node_modules/renovate/dist/platform/gitea/index.js:553:27)\n    at async Object.exports.isOnboarded (/usr/src/app/node_modules/renovate/dist/workers/repository/onboarding/branch/check.js:51:9)\n    at async Object.checkOnboardingBranch (/usr/src/app/node_modules/renovate/dist/workers/repository/onboarding/branch/index.js:14:29)\n    at async Object.initRepo (/usr/src/app/node_modules/renovate/dist/workers/repository/init/index.js:44:14)\n    at async Object.renovateRepository (/usr/src/app/node_modules/renovate/dist/workers/repository/index.js:37:18)\n    at async Object.start (/usr/src/app/node_modules/renovate/dist/workers/global/index.js:76:13)\n    at async /usr/src/app/node_modules/renovate/dist/renovate.js:28:24"
           },
           "msg": "Repository has unknown error"
         }

To Reproduce

Have more than [default pagination limit] issues closed + at least one open issue

Additional context

Gitea retuens x-total-count: 35 as header and 2 open issues in body. Renovate goes to ?page=2 which makes Gitea return same header and [] as body. Renovate crashes by attempting to perform ... on null.

@rarkins rarkins added type:bug Bug fix of existing functionality platform:gitea Gitea or Forgejo platforms priority-1-critical A bad bug or work that is holding up a lot of other important features or fixes labels Jun 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform:gitea Gitea or Forgejo platforms priority-1-critical A bad bug or work that is holding up a lot of other important features or fixes type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants