-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rename GraphQL query methods #6732
refactor: Rename GraphQL query methods #6732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to instead combine these into a single graphql
function with optional fieldName
param to distinguish between them?
let result = null; | ||
|
||
const path = 'graphql'; | ||
|
||
const { | ||
acceptHeader: accept = 'application/vnd.github.merge-info-preview+json', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it a mistake to have it in this file? Planning to correct it in a follow-up PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, after initRepo
refactoring PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it requires a fix or change to how headers are handled in this graphql, can it be done before?
{ paginate: false } | ||
); | ||
const nodes = await githubApi.queryRepoField<any>(query, 'pullRequests', { | ||
paginate: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I'm surprised to see pagination false for these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll enable it in separate PR then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to think why it was left with no pagination though
🎉 This PR is included in version 21.28.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Ref #6686