git-submodules manager doesn't work if config has pinning turned on

[mikebryant]

What Renovate type are you using?

self-hosted renovate pro

Describe the bug

If you turn pinning on (in our environment we have a default preset that turns pinning on for all repositories), git submodule updates silently do not work

Relevant debug logs

No relevant info

To Reproduce

Turn pinning on, observe submodules don't get any updates

Additional context

Traced through the code, found

renovate/lib/workers/repository/process/lookup/index.ts

Lines 379 to 394 in 76d8574

	} else if (config.pinDigests) {
	// Create a pin only if one doesn't already exists
	if (!res.updates.some((update) => update.updateType === 'pin')) {
	// pin digest
	res.updates.push({
	updateType: 'pin',
	newValue: config.currentValue,
	});
	}
	} else if (config.datasource === datasourceGitSubmodules.id) {
	const dependency = clone(await getPkgReleases(config));
	res.updates.push({
	updateType: 'digest',
	newValue: dependency.releases[0].version,
	});
	}

If config.pinDigests is true, we enter that first elseif section, and then skip out without anything useful happening - because the current version has the correct digest for the current version (it's the identity function for the submodule datasource / manager)

Maybe the first elseif section needs && config.datasource !== datasourceGitSubmodules.id? Or the order of the ifs could be changed.

[mikebryant]

This is our default preset: https://github.com/ocadotechnology/renovate-config-default/blob/master/renovate.json

[viceice]

you can add a packageRule to disable pinning for git-submodule manager

[mikebryant]

Yup, thank you, I'm attempting that now to work around this issue

[mikebryant]

This gives the desired effect as a workaround:

  "git-submodules": {
    "enabled": true,
    "pinDigests": false
  }

[mikebryant]

I actually disagree with this being in config-help - I still believe it's a bug in renovate itself. It's by no means obvious that you need to disable pinning for one particular type of dependency to work. At the very least the documentation would need to be updated to say there's a conflict between the two options.

I think a better route would be to fix the problem, so this sort of standard configuration just-works.

[viceice]

OK, you are right, fixing it asap

[renovate-release]

🎉 This issue has been resolved in version 21.29.3 🎉

The release is available on:

• GitHub release
• 21.29.3

Your semantic-release bot 📦🚀