chore(eslint): enable typescript 3.7 rules

[JamieMagee]

Enable prefer-optional-chain and prefer-nullish-coalescing and fix and occurences.

No failures with prefer-nullish-coalescing found. Might need to look at the options for that rule.

[JamieMagee]

I think I've addressed all your comments. Also there's a major version bump for eslint waiting, which might solve some of the issues with the nullish coalescing rule.

[viceice]

some snapshots are failed

[rarkins]

BTW I was looking for this eslint rule recently and didn't find it :)

Does it "auto fix" ?

[JamieMagee]

some snapshots are failed

I think this might be an error with the most recent commit. I'll check locally.

BTW I was looking for this eslint rule recently and didn't find it :)

Does it "auto fix" ?

You asking prompted me to look 😄

It does have an auto-fix, but it's still quite buggy and only recommended for the simplest cases. I did all of this by hand.

[viceice]

I think I've addressed all your comments. Also there's a major version bump for eslint waiting, which might solve some of the issues with the nullish coalescing rule.

Yes, we should update to new major linter versions, @types/eslint should be grouped to linters before. I'll see if i can do that at weekend. Or @JamieMagee have you time to arrange that?

[renovate-release]

🎉 This PR is included in version 21.32.3 🎉

The release is available on:

• GitHub release
• 21.32.3

Your semantic-release bot 📦🚀