feat(pip_setup): copy extract.py to repo #6768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested against real repo with and without docker. 🙃 |
JamieMagee
reviewed
Jul 17, 2020
data/extract.py
Outdated
Comment on lines
28
to
29
| with open('renovate-python-report.json', 'w', encoding='utf-8') as f: | ||
| json.dump(kwargs, f, ensure_ascii=False, indent=2) |
There was a problem hiding this comment.
Do we need to clean this up afterwards?
There was a problem hiding this comment.
Don't think so, we do the same with gradle (no cleanup)
JamieMagee
previously approved these changes
Jul 17, 2020
|
Do we need to make the file name sufficiently unique? |
|
Adapted from gradle manager, maybe it's better to write to |
|
I think this is fine now. We will hopefully have a js based manager soon. 🙃 |
viceice
changed the title
rarkins
approved these changes
Jul 18, 2020
rarkins
approved these changes
Jul 18, 2020
|
🎉 This PR is included in version 21.33.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract.pyto repo and call from therestdoutcloses: #6766