-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package.resolve isn't updated after update Package.swift #6924
Comments
Thanks, this feature is not yet supported. Please assist by providing:
|
@rarkins
renovate swift document: https://docs.renovatebot.com/modules/manager/swift
Just run
|
Definitely update and not resolve? Also I was hoping for Swift's own documentation rather than ours, plus any examples of running it in Ubuntu 18.04 under Docker, or something close. |
As you can see, Swift package manager documentation: |
I think we need to call |
I think it should be swift package resolve and not swift package update |
Official docker images: https://hub.docker.com/_/swift |
docker file: we need to update our buildpack and a new gitrepo for |
then renovate needs to extract tools version from comment to use correct swift version
|
We can use git-tags as datasource with a regex versioning swift-5.2.5-RELEASE I think we need use |
New repo: https://github.com/renovatebot/docker-swift Buildpack issue: renovatebot/docker-buildpack#50 |
Yes |
which swift version we should build? Where to start? v5, v5.3, v4 ... |
I propose v5.3, as this supports updating older resolved files and supports ubuntu 20.04 focal |
Thank you for providing a reproduction! 🎉 🚀 The Renovate team will take a look at the reproduction repository. Once we confirm the provided repository reproduces the problem, the label will be changed to |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Earlier today my Lead iOS Engineer raised this as being a useful feature addition to our Renovate workflow. Is there any pre-req items I should be aware of for this feature? I'd be happy to try and contribute it, although my interactions with Swift Package Manager are exactly |
Swift seems supported already in Containerbase: https://github.com/search?q=repo%3Acontainerbase%2Fbase%20swift&type=code Hopefully this reproduction repo is still valid: https://github.com/ra1028/sample-renovate6924 Hopefully running A simple/similar one I added recently is Bun: https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/bun/artifacts.ts The main difference here is that you probably don't want to treat it as a Buffer/binary file although even that might work. |
ok so there seams to be confusion about this. It should be
I will try to clarify why updating Package.swift for a dependency is not the way to go. The goal of the bot should be to detect wether there are updates available for the package. If versioning is done correctly it could suggest updates that can be done automatically. This is what So the update process is handled by
So in short if you would want to make the bot check wether ar not there are updates it should
The updated version should then be committed to the resolved file. When to update the Package.swift then? When the library needs features that are in the next version of the dependency, effectively making it incompatible with packages that cannot yet update to that version number. |
Swift runs just fine in linux and you have installation options at https://www.swift.org/install/#:~:text=on%20download%20page.-,Linux,-Docker As for github actions the latest ubuntu has swift build in so you do not need to do anything. |
What Renovate type are you using?
Renovate for GitHub
Describe the bug
Renovate supports Swift Package Manager, but
Package.resolved
isn't updated afterPackage.swift
is updated.That's a lock file of Swift tool dependencies, so it should be updated if it exists on git, otherwise, always diff will be made on the local environment after only
Package.swift
is updated.Relevant debug logs
There is no such thing as a log, as it's a specification failure, not a runtime error.
To Reproduce
This happens whenever there is an update to the Swift package listed in
Package.swift
.The text was updated successfully, but these errors were encountered: