Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): Support for per-host http concurrency limits #6983

Merged
merged 35 commits into from
Dec 11, 2020

Conversation

zharinov
Copy link
Collaborator

Closes #6358

lib/util/http/host-rules.ts Outdated Show resolved Hide resolved
lib/util/http/index.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/stats.ts Outdated Show resolved Hide resolved
lib/util/http/queue.ts Outdated Show resolved Hide resolved
lib/util/http/queue.ts Outdated Show resolved Hide resolved
lib/util/http/queue.ts Outdated Show resolved Hide resolved
@rarkins rarkins marked this pull request as draft August 24, 2020 09:30
lib/util/http/queue.ts Outdated Show resolved Hide resolved
lib/util/http/queue.ts Show resolved Hide resolved
lib/util/http/index.ts Outdated Show resolved Hide resolved
lib/util/http/index.ts Outdated Show resolved Hide resolved
lib/util/http/index.ts Outdated Show resolved Hide resolved
Sergio Zharinov added 5 commits October 4, 2020 15:57
…tp-concurrency-limit

# Conflicts:
#	lib/util/http/index.ts
#	lib/workers/repository/stats.ts
#	package.json
@zharinov
Copy link
Collaborator Author

zharinov commented Oct 4, 2020

Just received stats like this with queue of size 3:

DEBUG: http statistics (repository=zharinov/renovate-test-got-queue)
       "hostStats": [
         "api.github.com, 4 requests, 387ms request average, 0ms queue average",
         "repo.maven.apache.org, 1259 requests, 383ms request average, 2540ms queue average"
       ],
       "totalRequests": 1263

@zharinov zharinov marked this pull request as ready for review October 4, 2020 13:40
lib/util/http/index.ts Outdated Show resolved Hide resolved
lib/util/http/index.ts Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
zharinov and others added 2 commits December 3, 2020 15:16
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins
Copy link
Collaborator

rarkins commented Dec 4, 2020

@zharinov I think a good test would be a repo with >20 dependencies and then limit registry.npmjs.org to 2 concurrent requests

@rarkins rarkins marked this pull request as draft December 4, 2020 06:14
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@viceice
Copy link
Member

viceice commented Dec 4, 2020

@zharinov I think a good test would be a repo with >20 dependencies and then limit registry.npmjs.org to 2 concurrent requests

Maybe ours (forked of cause) 😏

@zharinov
Copy link
Collaborator Author

zharinov commented Dec 4, 2020

Here is the reason I'm not receiving PR from 16.04 to 20.04:

major: { enabled: false },

I guess, we can make workaround or something

UPD. Ah, commented to wrong PR instead of this one...

@rarkins
Copy link
Collaborator

rarkins commented Dec 4, 2020

Yes, fixing Ubuntu and Node versioning are our pre-requisites for removing that restriction :)

@zharinov
Copy link
Collaborator Author

zharinov commented Dec 7, 2020

Unlimited: repo.maven.apache.org, 1281 requests, 181ms request average, 0ms queue average
Limit = 2: repo.maven.apache.org, 1281 requests, 169ms request average, 1650ms queue average
Limit = 1: repo.maven.apache.org, 1281 requests, 194ms request average, 4040ms queue average

@zharinov zharinov marked this pull request as ready for review December 7, 2020 11:57
@rarkins rarkins merged commit 663117b into renovatebot:master Dec 11, 2020
@rarkins rarkins deleted the feat/http-concurrency-limit branch December 11, 2020 09:09
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support limiting concurrent requests per host
5 participants