Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): Add auth param to docker npm when trustlevel == high #7051

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

Chumper
Copy link
Contributor

@Chumper Chumper commented Aug 21, 2020

Add the conventional NPM_AUTH NPM_TOKEN and NPM_EMAIL to the extraEnv object when the trustLevel is set to high

Closes #6961

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2020

CLA assistant check
All committers have signed the CLA.

@Chumper Chumper force-pushed the fix/dockerNPMEnv branch 4 times, most recently from 1a0c19f to 6bf672b Compare August 21, 2020 10:41
@Chumper
Copy link
Contributor Author

Chumper commented Aug 21, 2020

Sorry for the fuss, I had to resolve the mail address problem with my work profile...

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore for coverage

lib/manager/npm/post-update/yarn.ts Show resolved Hide resolved
lib/manager/npm/post-update/pnpm.ts Show resolved Hide resolved
lib/manager/npm/post-update/npm.ts Show resolved Hide resolved
lib/manager/npm/post-update/lerna.ts Show resolved Hide resolved
@rarkins rarkins merged commit d59ac3b into renovatebot:master Aug 24, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 22.24.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
@Chumper Chumper deleted the fix/dockerNPMEnv branch January 10, 2021 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--binary-source docker does not pass environment variables
4 participants