Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency typescript to v4 #7092

Merged
merged 5 commits into from Sep 8, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 25, 2020

WhiteSource Renovate

This PR contains the following updates:

Package Update Type Change Sourcegraph
typescript (source) major devDependencies 3.9.7 -> 4.0.2 code search for "typescript"

Release Notes

Microsoft/TypeScript

v4.0.2

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the ready label Aug 25, 2020
@renovate renovate bot force-pushed the renovate/typescript-4.x branch 2 times, most recently from d66fc28 to 9109bf3 Compare August 25, 2020 11:20
@JamieMagee
Copy link
Contributor

Blocked by taoqf/node-html-parser#61. I'll try and contribute a fix upstream.

@renovate renovate bot force-pushed the renovate/typescript-4.x branch 5 times, most recently from 6599385 to 0e02cd4 Compare August 26, 2020 05:09
@viceice viceice marked this pull request as draft August 26, 2020 07:30
@renovate renovate bot force-pushed the renovate/typescript-4.x branch 19 times, most recently from d21064f to 40ef657 Compare August 29, 2020 13:01
@renovate renovate bot force-pushed the renovate/typescript-4.x branch 5 times, most recently from 4540d10 to f73b138 Compare September 5, 2020 21:02
@JamieMagee
Copy link
Contributor

Upstream isn't responsive to my patch, and it looks like the maintainer hasn't been active since June. I don't want to fork and maintain the package, so I'll switch out node-html-parser for cheerio instead.

@JamieMagee JamieMagee requested review from rarkins and viceice and removed request for rarkins September 7, 2020 07:03
@JamieMagee JamieMagee marked this pull request as ready for review September 7, 2020 07:04
@viceice
Copy link
Member

viceice commented Sep 7, 2020

I've found that jsdom is much more strict while parsing html. So is can throw errors if html structure is somehow invalid. 🤔

What alternatives do we have beside cheerio ?

@viceice
Copy link
Member

viceice commented Sep 7, 2020

maybe fork node-html-parser until upstream is fixed?

@JamieMagee
Copy link
Contributor

I've found that jsdom is much more strict while parsing html. So is can throw errors if html structure is somehow invalid.

What alternatives do we have beside cheerio ?

I chose jsdom as it is still being maintained, whereas cheerio's most recent release is an RC from 1 year ago or a 0.x version from 4 years ago. Also jsdom has a similar API to node-html-parser, compared to parse5 or htmlparser2 which I also considered.

maybe fork node-html-parser until upstream is fixed?

It's technically possible, but I'd prefer not to take on the maintenance burden. And it's hard to say if or when upstream will be fixed. the maintainer hasn't been active on GitHub for 3 months.

@viceice viceice merged commit 2d2e95c into master Sep 8, 2020
@viceice viceice deleted the renovate/typescript-4.x branch September 8, 2020 10:26
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 23.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants