-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(logger): Fix lint warnings #7109
Conversation
@@ -2,8 +2,20 @@ import is from '@sindresorhus/is'; | |||
|
|||
Error.stackTraceLimit = 20; | |||
|
|||
// eslint-disable-next-lint @typescript-eslint/explicit-module-boundary-types | |||
export default function errSerializer(err: any): any { | |||
interface Err { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 maybe we should reuse existing types here?
// TODO | ||
// eslint-disable-next-lint @typescript-eslint/explicit-module-boundary-types | ||
export function withSanitizer(streamConfig): bunyan.Stream { | ||
type BunyanStream = (NodeJS.WritableStream | Stream) & { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks little strange, but I'm ok if it improves types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, those types are tricky and it's hard to do something with it
🎉 This PR is included in version 23.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.