Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock file maintenance PR created in branch {{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}} #7110

Closed
DevRCRun opened this issue Aug 26, 2020 · 3 comments
Assignees

Comments

@DevRCRun
Copy link

DevRCRun commented Aug 26, 2020

What Renovate type, platform and version are you using?

Self hosted renovate npm module in azure pipelines (microsoft hosted) ubuntu-latest image
"renovateVersion": "23.1.0"

Describe the bug

Previous lock file maintenance PR on this repo have been created with the expected branch renovate/lock-file-maintenance, these were filed using the docker image.

I have now switched to using the npm module in azure pipelines and the branch is being created with the name

"{{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}"

Relevant debug logs

As best as I can see, renovate is not getting this from the repo itself, as it labels it "branch needs creating" and "branchExists=false"

It correctly identifies the other branches, two that already exist, and a new one that needs creating for tedious. I've stripped the majority of these logs out but let me know if you'd like to see them.

When first processing the repo and identifying branches

2020-08-26T10:27:10.4363266Z DEBUG: processRepo() (repository=myProject/myProject) 2020-08-26T10:27:10.4368597Z DEBUG: Processing 4 branches: renovate/jest-26.x, renovate/sequelize-6.x, renovate/tedious-9.x, {{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}} (repository=myProject/myProject)

When it goes to create the lockfilemaintenance branch

2020-08-26T10:27:18.7064852Z DEBUG: processBranch with 1 upgrades (repository=myProject/myProject, dependencies=, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:18.7065955Z DEBUG: Setting base branch to master (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:18.7067073Z DEBUG: Setting current branch to master (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:18.7322923Z DEBUG: latest commit (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:18.7323921Z "branchName": "master", 2020-08-26T10:27:18.7324673Z "latestCommitDate": "2020-08-18T09:19:04+00:00" 2020-08-26T10:27:19.1565222Z DEBUG: getBranchPr({{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:19.1567778Z DEBUG: getPrList() (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:19.1569815Z DEBUG: branchExists=false (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:19.1571634Z DEBUG: Branch has 0 upgrade(s) (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:19.1572729Z DEBUG: recreateClosed is true (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:19.1573824Z DEBUG: Checking schedule(every weekday, null) (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:19.1591838Z DEBUG: Checking 1 schedule(s) (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:19.1596700Z DEBUG: Checking schedule "every weekday" (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:19.1597953Z "parsedSchedule": {"schedules": [{"d": [2, 3, 4, 5, 6]}], "exceptions": [], "error": -1} 2020-08-26T10:27:19.1599717Z DEBUG: Matches schedule every weekday (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:19.1601161Z DEBUG: Branch needs creating (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:19.1602639Z DEBUG: Using reuseExistingBranch: false (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:19.1604045Z DEBUG: manager.getUpdatedPackageFiles() (repository=myProject/myProject, branch={{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}) 2020-08-26T10:27:19.1605186Z "reuseExistingBranch": false, 2020-08-26T10:27:19.1605708Z "branchName": "{{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}"

and when it echos out the branch list

2020-08-26T10:27:32.4360335Z DEBUG: Branch lists (repository=myProject/myProject) 2020-08-26T10:27:32.4361653Z "branchList": [ 2020-08-26T10:27:32.4364569Z "renovate/sequelize-6.x", 2020-08-26T10:27:32.4365701Z "renovate/tedious-9.x", 2020-08-26T10:27:32.4366820Z "renovate/jest-26.x", 2020-08-26T10:27:32.4367636Z "{{{branchPrefix}}}{{{managerBranchPrefix}}}{{{branchTopic}}}" 2020-08-26T10:27:32.4368340Z ],

To Reproduce

Let me know what you need here, happy to alter my config (which I based on your new docs at https://github.com/renovatebot/renovate/blob/master/docs/usage/setup-azure-devops.md ) and re-test. The config I am using is however very similar to that I was using with the docker image. It doesn't feel config related as the module updates are being created with correct branch names but apologies If I'm wrong.

Additional context

Many thanks for your time.

@rarkins rarkins self-assigned this Aug 26, 2020
@rarkins
Copy link
Collaborator

rarkins commented Aug 26, 2020

I can reproduce, looking into a fix now. Please try to downgrade to 23.0.x for now

@rarkins
Copy link
Collaborator

rarkins commented Aug 26, 2020

The fix for this should be in the next release which is currently building. Thanks for reporting the bug

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 23.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants