Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add docker image prefix #7164

Merged
merged 11 commits into from Sep 8, 2020
Merged

feat: add docker image prefix #7164

merged 11 commits into from Sep 8, 2020

Conversation

viceice
Copy link
Member

@viceice viceice commented Sep 2, 2020 •
edited

This allows to override the default renovate sidecar image names to be overridden.

By default renovate/nodeis now replaced by docker.io/renovate/node. If dockerImagePrefix='ghcr.io/renovatebot', the final image name is ghcr.io/renovatebot/node.

closes #6318
ref #7125

This is ment as a starter for futher discussion.

@viceice viceice mentioned this pull request Sep 2, 2020
Closed
@misterkramer
Copy link

misterkramer commented Sep 2, 2020 •
edited

This allows to override the default renovate sidecar image names to be overridden.

By default renovate/nodeis now replaced by docker.io/renovate/node. If dockerImagePrefix='ghcr.io/renovatebot', the final image name is ghcr.io/renovatebot/node.

closes #6318

ref #7125

This is ment as a starter for futher discussion.

Cool! It looks like a good option and should solve this issue #6318

Thank you for PR.

JamieMagee
JamieMagee previously approved these changes Sep 6, 2020
View reviewed changes
rarkins
rarkins requested changes Sep 6, 2020
View reviewed changes
lib/util/exec/docker/index.ts Outdated Show resolved Hide resolved
viceice and others added 2 commits September 7, 2020 09:42
@viceice viceice marked this pull request as ready for review September 7, 2020 08:30
@viceice
Copy link
Member Author

viceice commented Sep 8, 2020

@rarkins Any more changes requested?

rarkins
rarkins reviewed Sep 8, 2020
View reviewed changes
lib/config/common.ts
@@ -73,6 +73,10 @@ export interface RenovateAdminConfig {
baseDir?: string;
cacheDir?: string;
configWarningReuseIssue?: boolean;

dockerImagePrefix?: string;
dockerUser?: string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary for the PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but was missing anyway. I don't want to add a pr for just that simple type.

There are a lot more properties missing but becuase of extending Record somewhere it will mostly work. We should make that types more strict.

@viceice viceice merged commit 0503ad7 into master Sep 8, 2020
@viceice viceice deleted the feat/renovate-image-prefix branch September 8, 2020 10:59
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 23.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JamieMagee JamieMagee mentioned this pull request Sep 9, 2020
Closed
@ps-jay
Copy link

ps-jay commented Nov 22, 2020

Works well for me! Thanks @viceice

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamieMagee JamieMagee JamieMagee approved these changes

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docker-slim renovate image] replace the default index.docker.io
6 participants
@viceice @misterkramer @renovate-release @ps-jay @JamieMagee @rarkins