Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packageRules don’t match undefined depName #7462

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Oct 13, 2020

The empty depName in a lockFileMaintenance update was being matched positively against packagePatterns/excludePackagePatterns

Closes #7461

viceice
viceice previously approved these changes Oct 13, 2020
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add tests for it. 🙃

@rarkins rarkins merged commit 5e38204 into master Oct 13, 2020
@rarkins rarkins deleted the fix/7461-lock-exclude branch October 13, 2020 12:12
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 23.47.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lockFileMaintenance is never triggered
3 participants