Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate fails to update Dashboard #7486

Closed
sean-wallace opened this issue Oct 16, 2020 · 9 comments
Closed

Renovate fails to update Dashboard #7486

sean-wallace opened this issue Oct 16, 2020 · 9 comments
Assignees
Labels
type:bug Bug fix of existing functionality

Comments

@sean-wallace
Copy link

What Renovate type, platform and version are you using?

Self-hosted, GitLab, version 23.49.2

Describe the bug

My dashboard has fallen out of date and is no longer being updated to reflect manually-merged PRs.

I think release 23.49.1 introduced a bug here.
My dashboard has fallen out of date since 23.49.0

Relevant debug logs

Here is the log when I run 23.49.0 -- the lines between the comments are completely missing in 23.49.1.

DEBUG: getBranchPr(renovate/celery-5.x) (repository=analytics)
DEBUG: Got res with 1 results (repository=analytics)
DEBUG: getPr(123) (repository=analytics)
DEBUG: getBranchStatus(renovate/celery-5.x) (repository=analytics)
DEBUG: Got res with 4 results (repository=analytics)
DEBUG: getBranchPr(renovate/django-anymail-8.x) (repository=analytics)
DEBUG: Got res with 1 results (repository=analytics)
DEBUG: getPr(124) (repository=analytics)
DEBUG: getBranchStatus(renovate/django-anymail-8.x) (repository=analytics)
DEBUG: Got res with 4 results (repository=analytics)
# >>> Missing after this
DEBUG: Ensuring Dependency Dashboard (repository=analytics)
DEBUG: getBranchPr(renovate/celery-5.x) (repository=analytics)
DEBUG: Got res with 1 results (repository=analytics)
DEBUG: getPr(123) (repository=analytics)
DEBUG: getBranchStatus(renovate/celery-5.x) (repository=analytics)
DEBUG: Got res with 4 results (repository=analytics)
DEBUG: getBranchPr(renovate/django-anymail-8.x) (repository=analytics)
DEBUG: Got res with 1 results (repository=analytics)
DEBUG: getPr(124) (repository=analytics)
DEBUG: getBranchStatus(renovate/django-anymail-8.x) (repository=analytics)
DEBUG: Got res with 4 results (repository=analytics)
DEBUG: findPr(renovate/factory-boy-3.x, 📦 Update dependency factory-boy to v3.1.0, !open) (repository=analytics)
 INFO: DRY-RUN: Would ensure Dependency Dashboard 📦 Dependency Dashboard (repository=analytics)
# >>> Missing until this
DEBUG: Removing any stale branches (repository=analytics)
DEBUG: config.repoIsOnboarded=true (repository=analytics)

To Reproduce

Let me know if this would be helpful and I can try to put something together.

Additional context

@viceice
Copy link
Member

viceice commented Oct 16, 2020

are you referring to #7453? what is your config? is your repo onboarded?

moving this to config-help as i think this is a config issue.

@viceice viceice transferred this issue from renovatebot/renovate Oct 16, 2020
@sean-wallace
Copy link
Author

sean-wallace commented Oct 16, 2020

Thanks for the response. I'm a pretty new user so it could certainly be a config issue! It was working as expected up to version 23.49.0.

The repo is onboarded, config is in .renovaterc.json:

{
  "extends": [
    "config:base"
  ],
  "enabledManagers": ["pip_requirements"],
  "pip_requirements": {
    "fileMatch": [
      "^requirements/.*\\.txt$"
    ]
  },
  "gitLabAutomerge": true,
  "packageRules": [
    {
      "packageNames": ["psycopg2", "psycopg2-binary", "gunicorn", "setuptools"],
      "updateTypes": ["minor", "patch"],
      "groupName": "deployment",
      "automerge": true
    },
    {
      "packageNames": ["Werkzeug", "ipdb"],
      "updateTypes": ["minor", "patch"],
      "groupName": "development",
      "automerge": true
    },
    {
      "packageNames": [
        "black",
        "flake8",
        "isort",
        "pre-commit",
        "pylint-django",
        "pylint-celery"
      ],
      "updateTypes": ["minor", "patch"],
      "groupName": "code-quality"
    },
    {
      "packageNames": [
        "django-coverage-plugin",
        "django-stubs",
        "mypy",
        "pytest",
        "pytest-datafiles",
        "pytest-django",
        "pytest-sugar"
      ],
      "updateTypes": ["minor", "patch"],
      "groupName": "testing",
      "automerge": true
    },
    {
      "packageNames": ["numpy", "openpyxl", "pandas"],
      "updateTypes": ["minor", "patch"],
      "groupName": "analytics"
    }
  ],
  "labels": ["dependencies"],
  "assignees": ["wallace"],
  "commitMessagePrefix": "📦",
  "dependencyDashboard": true,
  "dependencyDashboardAutoclose": true,
  "dependencyDashboardTitle": "📦 Dependency Dashboard"
}

@rarkins
Copy link
Collaborator

rarkins commented Oct 16, 2020

The repo is onboarded, config is in .renovaterc.conf:

That's not a supported filename

@sean-wallace
Copy link
Author

The repo is onboarded, config is in .renovaterc.conf:

That's not a supported filename

Derp, it's .json.

@rarkins
Copy link
Collaborator

rarkins commented Oct 16, 2020

I've pushed a commit so that an extra debug message is logged if Renovate thinks it should skip the dashboard because of onboarding: 57dbcd5

Once that is in a release, you should get some message

@sean-wallace
Copy link
Author

sean-wallace commented Oct 16, 2020 via email

@sean-wallace
Copy link
Author

I am probably missing something, but should it maybe be checking config.repoIsOnboarded rather than config.onboarding because I think the latter is always going to be true unless I disable it in config.js?

@rarkins
Copy link
Collaborator

rarkins commented Oct 16, 2020

Yes, I think you're right

@rarkins rarkins transferred this issue from renovatebot/config-help Oct 16, 2020
@rarkins rarkins added the type:bug Bug fix of existing functionality label Oct 16, 2020
@rarkins rarkins self-assigned this Oct 16, 2020
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 23.49.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants