feat(submodules): cloneSubmodules option #7498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a couple of changes: - Added a new boolean config option cloneSubmodules (Defaults to `true` to be a non-breaking change) - Update submodules using `checkout` instead of `submdoule update --remote` - Remove usage of simple-git `silent()` as it's deprecated I wasn't able update a submodule using `update-index` and put the change in 'Changes not staged for commit'. I'm open to suggestions here. I have however changed the call from `git submodule update --init --remote` to a simple `git checkout`. The `--remote` flag updates the submodule to the latest commit at the remote, so there was a (very small chance) of a race condition here Closes #7472
rarkins
changed the title
rarkins
changed the title
rarkins
requested changes
Oct 19, 2020
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
viceice
requested changes
Oct 27, 2020
viceice
previously approved these changes
Oct 28, 2020
rarkins
reviewed
Oct 29, 2020
| @@ -106,7 +106,8 @@ export default async function extractPackageFile( | |||
| try { | |||
| const [currentValue] = (await git.subModule(['status', path])) | |||
| .trim() | |||
| .split(/[+\s]/); | |||
| .replace(/^[-+]/, '') | |||
There was a problem hiding this comment.
Is this fixing any open issue or just something you discovered?
There was a problem hiding this comment.
There isn't an open issue for this, but it does fix a bug
|
@JamieMagee lets split this pr. |
|
Okay, will create new PRs, and abandon this one. |
JamieMagee
added a commit
that referenced
this pull request
Nov 4, 2020
This is part 1 of #7498, and includes: - Added a new boolean config option cloneSubmodules (Defaults to `true` to be a non-breaking change)
This was referenced Nov 4, 2020
JamieMagee
added a commit
that referenced
this pull request
Nov 4, 2020
This is part 3 of #7498, and includes: - Correctly parse git submodule name
5 tasks
rarkins
pushed a commit
that referenced
this pull request
Nov 4, 2020
This is part 3 of #7498, and includes: - Correctly parse git submodule name
viceice
pushed a commit
that referenced
this pull request
Nov 4, 2020
This is part 3 of #7498, and includes: - Correctly parse git submodule name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a couple of changes:
trueto be a non-breaking change)checkoutinstead ofsubmdoule update --remotesilent()as it's deprecatedI wasn't able update a submodule using
update-indexand put the change in 'Changes not staged for commit'. I'm open to suggestions here. I have however changed the call fromgit submodule update --init --remoteto a simplegit checkout. The--remoteflag updates the submodule to the latest commit at the remote, so there was a (very small chance) of a race condition hereCloses #7472