feat(gradle-lite): JS-based Gradle manager #7521

zharinov · 2020-10-22T20:15:49Z

zharinov · 2020-10-22T20:18:35Z

https://github.com/zharinov/fineract/pulls
https://github.com/zharinov/web-frameworks/pull/1
https://github.com/zharinov/uPortal/pulls
https://github.com/zharinov/uPortal/pull/25/files
https://github.com/zharinov/gradle-template/pulls
https://github.com/zharinov/cas/pulls

zharinov · 2020-10-22T20:21:31Z

Ready for test runs, more thorough testing is required currently

rarkins · 2020-10-25T08:02:20Z

Challenge: could we rewrite this to be like a normal manager that takes one file instead of all files? so e.g. fileMatch will be for build.gradle. I know that each file would need to check for a "parent" etc but is there anything stopping us doing it that way?

zharinov · 2020-10-25T08:20:46Z

Technically, it's possible at the cost of missing upgrades for external variables.

But later, I think these upgrades can be handled too, if (1) we provide some way to sort packageFile in the same order Gradle would parse them and if (2) we can manage some per-repo and per-manager internal state between two extractDependencies() calls (i.e. variable registry). For autoreplace, we additionally would need (3) some way to point to the right file for replace.

zharinov · 2020-10-25T08:26:09Z

Actually, I tried to rely on autoreplace feature here, but then realized it won't work without per-file extraction.

viceice · 2020-10-25T08:52:55Z

Maybe we need to allow to return an additional optional target file string to support this. If I remember correctly we could use that in gitlab-include manager too.

…feat/gradle-lite

lib/manager/common.ts

zharinov · 2020-10-25T13:39:59Z

lib/manager/gradle-lite/parser.ts

+              fileReplacePosition: variable.fileReplacePosition,
+              packageFile: variable.packageFile,
+            };
+            dep.groupName = variable.key;


The potential problem here: same variable names in different files.
Possible solution: use packageFile in group name.

lib/manager/gradle-lite/parser.ts

JamieMagee · 2020-10-25T14:29:48Z

lib/manager/gradle-lite/utils.ts

+export function isDependencyString(input: string): boolean {
+  const split = input?.split(':');
+  if (split?.length !== 3) {
+    return false;
+  }
+  const [groupId, artifactId, versionPart] = split;
+  return (
+    groupId &&
+    artifactId &&
+    versionPart &&
+    artifactRegex.test(groupId) &&
+    artifactRegex.test(artifactId) &&
+    versionPart === versionLikeSubstring(versionPart)
+  );
+}


This doesn't match the alternative form of group: "com.example", name: "my.dependency", version: "1.2.3"

group: "com.example", name: "my.dependency", version: "1.2.3"

Can these named parameters go in any order?

yes, i think so. If i remember correctly it's like a hashtable, so order doesn't matter

Well, I think it's out of scope for now

rarkins · 2020-11-30T14:03:28Z

Let's aim to merge this disabled by default, so it's lowest risk. Then hopefully we get some feedback and can decide how to handle the two managers simultaneously.

viceice · 2020-11-30T14:17:07Z

yeah, I can enable it on my gradle repo's to validate, currently only one major update awaiting approval. But have soma basic test repos on github too

rarkins · 2020-11-30T15:20:39Z

Another alternative: let gradle-lite "replace" gradle on a per-dependency basis. e.g. if name/version/etc match then essentially delete the extracted dep from gradle and update it using gradle-lite instead. That way we can easily see which dependencies are found by gradle but missed by gradle-lite.

zharinov · 2020-11-30T15:32:29Z

Two points that potentially may complicate "wrapping" solution:

Gradle report contains lots of transitive dependencies, it may be hard to filter them from deps missed by gradle-lite
Recent gradle bugs are related to wrong update function, i.e. packages are detected but not updated correctly

rarkins · 2020-11-30T16:30:29Z

Gradle report contains lots of transitive dependencies, it may be hard to filter them from deps missed by gradle-lite

We can't update transitive dependencies, so how does the logic flow work today? e.g. do we still do a lookup and then attempt to update them but fail to update? Or is there a way that the existing manager filters them prior to update?

Recent gradle bugs are related to wrong update function, i.e. packages are detected but not updated correctly

So we should see some updates working correctly now rather than before, assuming the new manager detects them?

viceice

Just some suggestions, otherwise LGTM. I've not checked every line, as this is very big pr. Best is to merge it as disabled / beta feature. I'm happy to test it on my gradle repo to see it in action. 🙃

lib/manager/common.ts

lib/manager/gradle-lite/index.ts

viceice · 2020-12-03T07:27:31Z

lib/manager/gradle-lite/readme.md

@@ -0,0 +1 @@
+This is an alternate manager for Gradle, written completely in JavaScript.


We should add some more description, so users are welcome to disable default gradle and test this new manager, as we plan to replace to old in future.

My additions are not ideal, but at least someone can correct me instead of writing from scratch.

Maybe @HonkingGoose has some time to review this 🙃

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

rarkins · 2020-12-04T06:16:44Z

@zharinov what's the expected result when both gradle managers are enabled at the same time? e.g is there a predictable order of which manager updates first? Is it handled gracefully? Are the updates de-duplicated in the PR description?

…feat/gradle-lite

viceice

LGTM to me

viceice · 2020-12-07T15:59:25Z

lib/manager/gradle-lite/readme.md

@@ -0,0 +1 @@
+This is an alternate manager for Gradle, written completely in JavaScript.


Maybe @HonkingGoose has some time to review this 🙃

zharinov · 2020-12-07T16:14:32Z

I guess, it's a good time to release it. From this point, all bugs can be handled as separate issues.

lib/manager/gradle-lite/readme.md

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

viceice

Time to merge this 🙃

JamieMagee · 2020-12-08T09:49:49Z

I'm very interested to see how this goes! 🎉

renovate-release · 2020-12-08T13:20:15Z

🎉 This PR is included in version 23.97.0 🎉

The release is available on:

GitHub release
23.97.0

Your semantic-release bot 📦🚀

feat(gradle-lite): JS-based Gradle manager

26832c6

Sergio Zharinov added 14 commits October 23, 2020 09:17

Generalize syntax matching

7f085ac

Refactor test

adce21f

More tests

f2fb2c1

Support plugins

14efc8d

Inherit variables from parent dirs

9d4702c

Fix deps in properties

c9148ec

Fix extraction report

0c2777b

Guard for potentially infinite loop

e86bd77

Fix test

7d806ab

Add readme

3facd0b

Cleanup tokenizer part

53bc31e

Refactor dependency string regexes

bb4ceda

Null-safe dependency string check

d49d297

Cleanup parser part

62df8f0

Sergio Zharinov and others added 4 commits October 25, 2020 12:06

Add tests for parser

2145efe

Merge branch 'master' into feat/gradle-lite

a11629a

Fix test, coverage and catch parsing errors

559e894

Merge branch 'feat/gradle-lite' of github.com:zharinov/renovate into …

9b90285

…feat/gradle-lite

zharinov marked this pull request as ready for review October 25, 2020 10:43

zharinov commented Oct 25, 2020

View reviewed changes

lib/manager/common.ts Show resolved Hide resolved

zharinov commented Oct 25, 2020

View reviewed changes

JamieMagee reviewed Oct 25, 2020

View reviewed changes

lib/manager/gradle-lite/parser.ts Outdated Show resolved Hide resolved

JamieMagee reviewed Oct 25, 2020

View reviewed changes

viceice reviewed Dec 3, 2020

View reviewed changes

Update lib/manager/gradle-lite/index.ts

e287195

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

viceice and others added 3 commits December 7, 2020 14:10

Merge branch 'master' into feat/gradle-lite

e23efbf

Update readme

f3a8df8

Merge branch 'feat/gradle-lite' of github.com:zharinov/renovate into …

9e8c72a

…feat/gradle-lite

viceice previously approved these changes Dec 7, 2020

View reviewed changes

viceice requested review from HonkingGoose, rarkins and JamieMagee December 7, 2020 15:59

Merge branch 'master' into feat/gradle-lite

522dcdd

Merge branch 'master' into feat/gradle-lite

eb90a67

HonkingGoose reviewed Dec 7, 2020

View reviewed changes

lib/manager/gradle-lite/readme.md Outdated Show resolved Hide resolved

Update lib/manager/gradle-lite/readme.md

32df104

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

zharinov dismissed viceice’s stale review via 32df104 December 8, 2020 08:58

zharinov requested a review from viceice December 8, 2020 08:58

viceice approved these changes Dec 8, 2020

View reviewed changes

Merge branch 'master' into feat/gradle-lite

ef0e900

JamieMagee approved these changes Dec 8, 2020

View reviewed changes

rarkins merged commit c43a4dc into renovatebot:master Dec 8, 2020

rarkins deleted the feat/gradle-lite branch December 8, 2020 12:56

github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(gradle-lite): JS-based Gradle manager #7521

feat(gradle-lite): JS-based Gradle manager #7521

zharinov commented Oct 22, 2020 •

edited

zharinov commented Oct 22, 2020 •

edited

zharinov commented Oct 22, 2020

rarkins commented Oct 25, 2020

zharinov commented Oct 25, 2020

zharinov commented Oct 25, 2020

viceice commented Oct 25, 2020

zharinov Oct 25, 2020

zharinov Oct 25, 2020

JamieMagee Oct 25, 2020

zharinov Oct 25, 2020 •

edited

viceice Nov 30, 2020

zharinov Nov 30, 2020

rarkins commented Nov 30, 2020

viceice commented Nov 30, 2020

rarkins commented Nov 30, 2020

zharinov commented Nov 30, 2020

rarkins commented Nov 30, 2020

viceice left a comment

viceice Dec 3, 2020

zharinov Dec 7, 2020

viceice Dec 7, 2020

rarkins commented Dec 4, 2020

viceice left a comment

viceice Dec 7, 2020

zharinov commented Dec 7, 2020

viceice left a comment

JamieMagee commented Dec 8, 2020

renovate-release commented Dec 8, 2020

		@@ -0,0 +1 @@
		This is an alternate manager for Gradle, written completely in JavaScript.

feat(gradle-lite): JS-based Gradle manager #7521

feat(gradle-lite): JS-based Gradle manager #7521

Conversation

zharinov commented Oct 22, 2020 • edited

zharinov commented Oct 22, 2020 • edited

zharinov commented Oct 22, 2020

rarkins commented Oct 25, 2020

zharinov commented Oct 25, 2020

zharinov commented Oct 25, 2020

viceice commented Oct 25, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zharinov Oct 25, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rarkins commented Nov 30, 2020

viceice commented Nov 30, 2020

rarkins commented Nov 30, 2020

zharinov commented Nov 30, 2020

rarkins commented Nov 30, 2020

viceice left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rarkins commented Dec 4, 2020

viceice left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zharinov commented Dec 7, 2020

viceice left a comment

Choose a reason for hiding this comment

JamieMagee commented Dec 8, 2020

renovate-release commented Dec 8, 2020

zharinov commented Oct 22, 2020 •

edited

zharinov commented Oct 22, 2020 •

edited

zharinov Oct 25, 2020 •

edited