-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve pull request template #7576
Conversation
By the way, I'm using the new template here. So you can see how it looks. 馃槃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like it
Co-authored-by: Rhys Arkins <rhys@arkins.net>
I think the conventional commits reference is a bit "heavy" and could put people off who aren't familiar with it. I suggest either:
|
I've removed the reference to the Conventional Commits style guide. Less is more. 馃槃 |
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@rarkins I've implemented your review feedback, fixed the small Prettier linting issue that your suggestion caused, and merged the current I think this is ready for another round of review. 馃槃 |
馃帀 This PR is included in version 23.61.6 馃帀 The release is available on:
Your semantic-release bot 馃摝馃殌 |
Changes:
Context:
The pull request template needs to be updated.
This pull request template incorporates the good stuff from the discussion at issue #5189.
Closes #5189
Documentation (please tick one)
How I've tested my work (please tick one)
I have verified these changes via: