Renovate a bit too eager to close PRs

[k4y4k]

Which Renovate are you using?

WhiteSource Renovate App

Which platform are you using?

GitHub.com

What would you like to do?

Howdy 👋

I (want to) use bors-ng to merge my Renovate PRs. In the beginning I could - Renovate left a comment triggering a merge as soon as my tests passed, and didn't if there was an issue. This was great.

Then I added a schedule (before 0300 Monday [Australia/Brisbane]). As far as I can tell, this is when my issues started.

Renovate now leaves a merge comment and immediately closes the PR. This then generates the "we'll ignore this" message and makes my repos' PR history (and notifications) really ugly, littering them with misleading "PR Closed" statuses. Bors still merges updates, but it's super messy and just overall feels jank.

This has been bugging me for a while. I've finally (finally!) decided to do something about it. Any ideas? Did I put the schedule in the wrong place?

Config [renovate.json]

{
  "extends": ["config:base"],
  "dependencyDashboard": true,
  "packageRules": [
    {
      "updateTypes": ["minor", "patch", "pin", "digest"],
      "automerge": true,
      "automergeType": "pr-comment",
      "automergeComment": "bors: r+"
    }
  ],
  "schedule": ["before 3am on Monday"],
  "timezone": "Australia/Brisbane"
}

Logs here (Gist)

[rarkins]

This seems like a bug in our "delete automerged pull requests" feature. We shouldn't do it when merging with a comment

[k4y4k]

👌 epic and cool, thank you

[renovate-release]

🎉 This issue has been resolved in version 23.84.12 🎉

The release is available on:

• GitHub release
• 23.84.12

Your semantic-release bot 📦🚀