feat(util): Add resolveBaseUrl function #7918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2020
Closed
viceice
previously approved these changes
Dec 9, 2020
rarkins
reviewed
Dec 9, 2020
lib/util/url.ts
Outdated
| } | ||
|
|
||
| const result = host ? inputString : urlJoin(baseUrl, pathname || ''); | ||
| return result.replace(/\/+$/, ''); |
There was a problem hiding this comment.
Are we certain that we always want to strip the trailing slash?
There was a problem hiding this comment.
Let's preserve, except strings like these /foo/?bar=baz (normalized by url-join)
|
🎉 This PR is included in version 23.99.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Added
resolveBaseUrlfunction with behavior described in #7317.Migrations from
URL.resolve()will be made in separate PRs.Context:
Ref: #7317
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: