-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gitea): support presets #7920
Conversation
| GitHub with preset name | `github>abc/foo:xyz` | `xyz` | `https://github.com/abc/foo` | `xyz.json` | | ||
| GitLab default | `gitlab>abc/foo` | `default` | `https://gitlab.com/abc/foo` | `default.json` or `renovate.json` | | ||
| GitLab with preset name | `gitlab>abc/foo:xyz` | `xyz` | `https://gitlab.com/abc/foo` | `xyz.json` | | ||
| Gitea default | `gitea>abc/foo` | `default` | `https://gitea.com/abc/foo` | `default.json` or `renovate.json` | | ||
| Gitea with preset name | `gitea>abc/foo:xyz` | `xyz` | `https://gitea.com/abc/foo` | `xyz.json` | | ||
| Local default | `local>abc/foo` | `default` | `https://github.company.com/abc/foo` | `default.json` or `renovate.json` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we have duplicated this table ? I think we can remove one of them from shareable-configs
or config-presets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I noticed that as well. I think it's for ease of use for the readers. Because the table is helpful in the shareable -configs
, and in the config-presets
documentation.
Duplicating things is never good, so we probably should make a "re-usable component" out of the table, and then insert this component into the docs in the relevant places. This way we have one source of truth for the table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created issue #7924 to discuss this problem.
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
🎉 This PR is included in version 23.99.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Support hosting presets on gitea.com and /or local.
Context:
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: