Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gitea): support presets #7920

Merged
merged 8 commits into from
Dec 9, 2020
Merged

feat(gitea): support presets #7920

merged 8 commits into from
Dec 9, 2020

Conversation

viceice
Copy link
Member

@viceice viceice commented Dec 9, 2020

Changes:

Support hosting presets on gitea.com and /or local.

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Unit tests + ran on a real repository

@viceice viceice marked this pull request as ready for review December 9, 2020 08:43
@viceice viceice marked this pull request as draft December 9, 2020 08:46
@viceice viceice changed the title feat(gitea): support local presets feat(gitea): support presets Dec 9, 2020
@viceice viceice marked this pull request as ready for review December 9, 2020 08:52
Comment on lines 55 to 60
| GitHub with preset name | `github>abc/foo:xyz` | `xyz` | `https://github.com/abc/foo` | `xyz.json` |
| GitLab default | `gitlab>abc/foo` | `default` | `https://gitlab.com/abc/foo` | `default.json` or `renovate.json` |
| GitLab with preset name | `gitlab>abc/foo:xyz` | `xyz` | `https://gitlab.com/abc/foo` | `xyz.json` |
| Gitea default | `gitea>abc/foo` | `default` | `https://gitea.com/abc/foo` | `default.json` or `renovate.json` |
| Gitea with preset name | `gitea>abc/foo:xyz` | `xyz` | `https://gitea.com/abc/foo` | `xyz.json` |
| Local default | `local>abc/foo` | `default` | `https://github.company.com/abc/foo` | `default.json` or `renovate.json` |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we have duplicated this table ? I think we can remove one of them from shareable-configs or config-presets

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I noticed that as well. I think it's for ease of use for the readers. Because the table is helpful in the shareable -configs, and in the config-presets documentation.

Duplicating things is never good, so we probably should make a "re-usable component" out of the table, and then insert this component into the docs in the relevant places. This way we have one source of truth for the table.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created issue #7924 to discuss this problem.

rarkins
rarkins previously approved these changes Dec 9, 2020
JamieMagee
JamieMagee previously approved these changes Dec 9, 2020
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@viceice viceice merged commit f18b7f3 into master Dec 9, 2020
@viceice viceice deleted the feat/gitea-local-presets branch December 9, 2020 12:31
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 23.99.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants