Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[poetry] detect if allow-prereleases=true #7922

Closed
MrGreenTea opened this issue Dec 7, 2020 · 7 comments
Closed

[poetry] detect if allow-prereleases=true #7922

MrGreenTea opened this issue Dec 7, 2020 · 7 comments

Comments

@MrGreenTea
Copy link

What would you like Renovate to be able to do?

currently, If I have a pyproject.toml like this I won't get updates for the version 1.1a1 of example.

[tool.poetry.dependencies]
python = "^3.9"
example = { version = "1.0", allow-prereleases=true }

With some guidance/introduction I could see myself implementing this.

@viceice viceice transferred this issue from renovatebot/renovate Dec 7, 2020
@viceice
Copy link
Member

viceice commented Dec 7, 2020

try ignoreUnstable config option, eg something like:

packageRules: [
  {
  packageNames: ["example"],
  ignoreUnstable: true
  }
]

@MrGreenTea
Copy link
Author

try ignoreUnstable config option, eg something like:

packageRules: [
  {
  packageNames: ["example"],
  ignoreUnstable: true
  }
]

Thanks for the info, that helps already. Would it be possible to support this information from the pyproject.toml directly? I've looked at the implementation and it seems you're rewriting it to use actual PEP440 versions instead of the npm compatibility. Who could I talk to about some introductional guidance?

@viceice
Copy link
Member

viceice commented Dec 9, 2020

First thing is to raise a feature request, so renovate translates allow-prereleases=true to ignoreUnstable: true.

The we can give some advice / discussion how to implement.

@rarkins
Copy link
Collaborator

rarkins commented Dec 9, 2020

Yes, please create a feature request issue in https://github.com/renovatebot/renovate with details + an example repo to test against.

@rarkins rarkins closed this as completed Dec 9, 2020
@MrGreenTea
Copy link
Author

First thing is to raise a feature request, so renovate translates ``allow-prereleases=truetoignoreUnstable: true`.

The we can give some advice / discussion how to implement.

Yes, please create a feature request issue in https://github.com/renovatebot/renovate with details + an example repo to test against.

That's what I did originally, this issue was transferred from there.

@rarkins rarkins reopened this Dec 9, 2020
@rarkins
Copy link
Collaborator

rarkins commented Dec 9, 2020

OK, we can reopen and transfer, but it is lacking requirements/reproduction as-is

@rarkins rarkins transferred this issue from renovatebot/config-help Dec 9, 2020
@rarkins rarkins added manager:poetry Poetry package manager priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality) labels Dec 9, 2020
@rarkins rarkins changed the title [poetry] updates to pre-release versions are not provided if allow-prereleases=true [poetry] detect if allow-prereleases=true Dec 9, 2020
@rarkins rarkins added the status:requirements Full requirements are not yet known, so implementation should not be started label Jan 12, 2021
@rarkins rarkins added the auto:reproduction A minimal reproduction is necessary to proceed label May 14, 2023
@github-actions
Copy link
Contributor

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

@rarkins rarkins removed type:feature Feature (new functionality) priority-4-low Low priority, unlikely to be done unless it becomes important to more people manager:poetry Poetry package manager auto:reproduction A minimal reproduction is necessary to proceed status:requirements Full requirements are not yet known, so implementation should not be started labels Oct 1, 2023
@renovatebot renovatebot locked and limited conversation to collaborators Oct 1, 2023
@rarkins rarkins converted this issue into discussion #24777 Oct 1, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants