New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve Docker documentation #7925
Conversation
This comment has been minimized.
This comment has been minimized.
@rarkins This is ready for another round of review. 😄 Can you check my work with the version numbers, and see if it makes sense to you? I've also rewritten the confusing section that mentioned why you should switch from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use myimage instead of node in examples. Any similar name would suffice too - let's just use one that is not known to the user already and is clearly a "dummy" name
Co-authored-by: Rhys Arkins <rhys@arkins.net>
That was a really good idea, it's way clearer now. Thanks! 😄 |
I'll go fix the merge conflict 😄. Edit: it's fixed now. |
🎉 This PR is included in version 24.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Big:
myimage
instead ofnode
for version number examplesSmaller:
1.
's to number itemsfiles
at end of list itemdocker-compose.yml
by name in list itembehavior
h5
headings toh3
level headingsContext:
Helps with issue #7626.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: