refactor(limits): Refactor global limits counter #7931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Dec 10, 2020
lib/workers/global/limits.ts
Outdated
Comment on lines
27
to
29
| if (val > 0) { | ||
| max = val; | ||
| } |
There was a problem hiding this comment.
Is this for backwar compability?
There was a problem hiding this comment.
Yes. Well, I think we can get rid of this flag completely.
added 2 commits
December 10, 2020 09:34
rarkins
reviewed
Dec 10, 2020
lib/workers/global/limits.ts
Outdated
| ...limit, | ||
| max: maxVal, | ||
| }); | ||
| if (max === null || typeof max === 'number') { |
There was a problem hiding this comment.
What's the difference here - undefined is skipped altogether?
There was a problem hiding this comment.
Never mind, undefined now also means limit reset
|
🎉 This PR is included in version 23.100.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Introduce
allowUnlimitedflag:truefor commit per-run setting. Can be set via CLI only.falsefor PR and branch per-repo limits. Options are set via config, but max limit values are calculated per-repo and can be 0 when limit reached.Context:
Ref: #7198
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: