Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: secrets #8070

Merged
merged 37 commits into from Mar 22, 2021
Merged

feat: secrets #8070

merged 37 commits into from Mar 22, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Dec 18, 2020

Changes:

As per #6664, but hopefully not broken this time.

Context:

#6662, #8066

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice December 18, 2020 14:36
@viceice
Copy link
Member

viceice commented Dec 23, 2020

Maybe we should defer any bigger change until next year. 😏

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs deconflicting

@rarkins rarkins enabled auto-merge (squash) March 22, 2021 08:13
@rarkins rarkins requested a review from viceice March 22, 2021 08:28
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@rarkins rarkins merged commit af1e4ee into master Mar 22, 2021
@rarkins rarkins deleted the feat/6662-secrets branch March 22, 2021 14:51
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.92.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants