Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batect): Automatically extract dependencies for files included into Batect configuration #8091

Merged
merged 8 commits into from
Dec 21, 2020

Conversation

charleskorn
Copy link
Contributor

Changes:

This PR adds support for automatically identifying and updating dependencies in files included into the main batect.yml or batect-bundle.yml file without requiring them to be configured with fileMatch.

Context:

Batect supports including configuration from other files into the main configuration file, for example:

include:
  - include.yml
  - subdir/file.yml

  - type: file
    path: another-include.yml

Without this PR, a user would need to configure the batect manager's fileMatch to include the included files (eg. include.yml, subdir/file.yml and another-include.yml). This PR adds support for automatically discovering these includes, provided the main configuration file is covered by fileMatch.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Unit tests + ran on a real repository

This change can be tested against https://github.com/charleskorn/golang-bundle - Renovate should identify the bundle references in include.yml without configuring Renovate to check include.yml specifically.

lib/manager/batect/extract.ts Outdated Show resolved Hide resolved
lib/manager/batect/extract.ts Outdated Show resolved Hide resolved
@viceice
Copy link
Member

viceice commented Dec 20, 2020

Needs snapshot update.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just some small suggestions.

lib/manager/batect/extract.ts Show resolved Hide resolved
lib/manager/batect/extract.ts Outdated Show resolved Hide resolved
lib/manager/batect/extract.ts Outdated Show resolved Hide resolved
JamieMagee
JamieMagee previously approved these changes Dec 21, 2020
@rarkins rarkins merged commit 61da4d6 into renovatebot:master Dec 21, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

charleskorn added a commit to batect/batect.dev that referenced this pull request Dec 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants