-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(batect): Automatically extract dependencies for files included into Batect configuration #8091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Dec 20, 2020
Needs snapshot update. |
rarkins
reviewed
Dec 20, 2020
JamieMagee
reviewed
Dec 20, 2020
JamieMagee
reviewed
Dec 20, 2020
viceice
reviewed
Dec 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, just some small suggestions.
JamieMagee
previously approved these changes
Dec 21, 2020
viceice
approved these changes
Dec 21, 2020
🎉 This PR is included in version 24.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
charleskorn
added a commit
to batect/batect.dev
that referenced
this pull request
Dec 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR adds support for automatically identifying and updating dependencies in files included into the main
batect.yml
orbatect-bundle.yml
file without requiring them to be configured withfileMatch
.Context:
Batect supports including configuration from other files into the main configuration file, for example:
Without this PR, a user would need to configure the
batect
manager'sfileMatch
to include the included files (eg.include.yml
,subdir/file.yml
andanother-include.yml
). This PR adds support for automatically discovering these includes, provided the main configuration file is covered byfileMatch
.Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
This change can be tested against https://github.com/charleskorn/golang-bundle - Renovate should identify the bundle references in
include.yml
without configuring Renovate to checkinclude.yml
specifically.