Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbt): Append additional registry URL for Sbt plugins #8105

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

zharinov
Copy link
Collaborator

Context:

Closes #8093

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Unit tests + ran on a real repository

@zharinov
Copy link
Collaborator Author

Example: https://github.com/zharinov/cucumber-jvm-scala/pulls

Another option was to just append MAVEN_REPO to Sbt plugin default urls, but seems like we don't merge/fallback with these defaults in case if custom URLs are failed.

@rarkins rarkins merged commit ed9fe83 into renovatebot:master Dec 21, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gaeljw
Copy link
Contributor

gaeljw commented Dec 21, 2020

Awesome, thanks a lot!

The speed at which you solve issues is mind-blowing, great great job 👍👍👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sbt] New version resolution for plugins not published to Maven Central
5 participants