Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support template in labels #8138

Merged
merged 2 commits into from
Dec 30, 2020
Merged

feat: support template in labels #8138

merged 2 commits into from
Dec 30, 2020

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Dec 25, 2020

Changes:

  • Add addLabels and labels to exposedConfigOptions
  • When a pull request is created, compile labels with template

Context:

Closes #8137

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Dec 25, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a test repo with sample pr

@suzuki-shunsuke
Copy link
Contributor Author

suzuki-shunsuke commented Dec 28, 2020

Thank you for your review.

I have created a sample repo and prs.

~/repos/src/github.com/renovatebot/renovate feat/expose-labels
❯ git rev-parse HEAD
b4fae8252283ab0a8bb442e0b7571e6bab2ff405

~/repos/src/github.com/renovatebot/renovate feat/expose-labels
❯ git status
On branch feat/expose-labels
nothing to commit, working tree clean

~/repos/src/github.com/renovatebot/renovate feat/expose-labels
❯ yarn start minimum-core/test-renovate
yarn run v1.22.4
$ run-s generate:* 
$ node tmp/tools/generate-imports.js
generating imports
> data/extract.py
> data/node-js-schedule.json
> lib/datasource/
> lib/manager/
> lib/platform/
> lib/versioning/
$ babel-node --extensions ".ts,.js" -- lib/renovate.ts minimum-core/test-renovate
 INFO: Repository started (repository=minimum-core/test-renovate)
       "renovateVersion": "0.0.0-semantic-release"
 INFO: Dependency extraction complete (repository=minimum-core/test-renovate)
       "baseBranch": "main",
       "stats": {
         "managers": {"helmfile": {"fileCount": 1, "depCount": 3}},
         "total": {"fileCount": 1, "depCount": 3}
       }
 INFO: Branch created (repository=minimum-core/test-renovate, branch=renovate/helmfile-datadog-2.x)
       "commitSha": "e62b223"
 INFO: PR created (repository=minimum-core/test-renovate, branch=renovate/helmfile-datadog-2.x)
       "pr": 6,
       "prTitle": "Update Helm release datadog to v2.6.7 (helmfile)"
 INFO: Branch created (repository=minimum-core/test-renovate, branch=renovate/helmfile-ingress-nginx-3.x)
       "commitSha": "e8ed97c"
 INFO: PR created (repository=minimum-core/test-renovate, branch=renovate/helmfile-ingress-nginx-3.x)
       "pr": 7,
       "prTitle": "Update Helm release ingress-nginx to v3.17.0 (helmfile)"
 INFO: Branch created (repository=minimum-core/test-renovate, branch=renovate/helmfile-velero-2.x)
       "commitSha": "3906b71"
 INFO: PR created (repository=minimum-core/test-renovate, branch=renovate/helmfile-velero-2.x)
       "pr": 8,
       "prTitle": "Update Helm release velero to v2.14.4 (helmfile)"
 INFO: Repository finished (repository=minimum-core/test-renovate)
       "durationMs": 45903
✨  Done in 52.15s.
❯ node --version
v12.13.0

❯ yarn --version
1.22.4

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for second review to approve the approach.

@rarkins rarkins merged commit de852ac into renovatebot:master Dec 30, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@suzuki-shunsuke suzuki-shunsuke deleted the feat/expose-labels branch December 30, 2020 11:41
suzuki-shunsuke added a commit to suzuki-shunsuke/test-renovate-2 that referenced this pull request Dec 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support template in labels
5 participants