Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovates fails during config validation #8371

Closed
1 of 5 tasks
erezrokah opened this issue Jan 21, 2021 · 9 comments · Fixed by #8370
Closed
1 of 5 tasks

Renovates fails during config validation #8371

erezrokah opened this issue Jan 21, 2021 · 9 comments · Fixed by #8370
Labels
type:bug Bug fix of existing functionality

Comments

@erezrokah
Copy link

erezrokah commented Jan 21, 2021

What Renovate type, platform and version are you using?

I'm using renovate with a GitHub app. Logs say renovate version is 24.26.2

Describe the bug

Renovated started failing during config validation without any changes on my end.

Relevant debug logs

DEBUG: Preset fetch error
{
  "preset": "workarounds:ignoreSbtLatestIntegration",
  "err": {
    "message": "Cannot convert undefined or null to object",
    "stack": "TypeError: Cannot convert undefined or null to object
  at Function.keys (<anonymous>)
  at getPreset (/home/ubuntu/renovateapp/node_modules/renovate/dist/config/presets/index.js:178:31)
  at runMicrotasks (<anonymous>)
  at processTicksAndRejections (internal/process/task_queues.js:97:5)
  at async resolveConfigPresets (/home/ubuntu/renovateapp/node_modules/renovate/dist/config/presets/index.js:222:37)
  at async resolveConfigPresets (/home/ubuntu/renovateapp/node_modules/renovate/dist/config/presets/index.js:252:38)
  at async Object.resolveConfigPresets (/home/ubuntu/renovateapp/node_modules/renovate/dist/config/presets/index.js:252:38)
  at async mergeRenovateConfig (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/init/config.js:194:52)
  at async Object.getRepoConfig (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/init/config.js:231:14)
  at async Object.initRepo (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/init/index.js:19:14)
  at async Object.renovateRepository (/home/ubuntu/renovateapp/node_modules/renovate/dist/workers/repository/index.js:60:18)
  at async renovateRepository (/home/ubuntu/renovateapp/app/worker/index.js:359:26)
  at async /home/ubuntu/renovateapp/app/worker/index.js:587:5"
  }
}

Have you created a minimal reproduction repository?

Please read the minimal reproductions documentation to learn how to make a good minimal reproduction repository.

  • This is a really small bug, it does not need a reproduction (think small typo)
  • I have provided a minimal reproduction repository
  • I don't have time for that, but it happens in a public repository I have linked to
  • I don't have time for that, and cannot share my private repository
  • The nature of this bug means it's impossible to reproduce publicly

Additional context

Linked repo https://github.com/erezrokah/2fa-with-slack-action/blob/92f87c4678a98999ba2e0a12d540ca2f42fa1c97/renovate.json

Issue erezrokah/2fa-with-slack-action#237

@xoxys
Copy link

xoxys commented Jan 21, 2021

Same here...

@viceice
Copy link
Member

viceice commented Jan 21, 2021

Already fixed in master. Please wait for new deplyoment

@viceice
Copy link
Member

viceice commented Jan 21, 2021

ref #8363,#8370

@broksonic21
Copy link

I put a minimal public repo up at https://github.com/broksonic21/renovate_repo_repro/issues/4 (via #8373, which is likely a duplicate) if it helps

@viceice viceice added the type:bug Bug fix of existing functionality label Jan 21, 2021
@rarkins
Copy link
Collaborator

rarkins commented Jan 21, 2021

Sorry, bad commit now rolled back in the app. The warning issue in repos will be automatically closed on the next run.

@viceice
Copy link
Member

viceice commented Jan 21, 2021

@broksonic21 Bug is already fixed and waits for ci release

@broksonic21
Copy link

thanks! for our knowledge, how long does that take?

@rarkins
Copy link
Collaborator

rarkins commented Jan 21, 2021

The new npm version is published and the app is already rolled back to the last good. Renovate runs continuously so will close the issues the next time it runs on the repo (approximately once per hour). It's perfectly OK to manually close issues in the meantime if you prefer

@mrlubos
Copy link

mrlubos commented Jan 21, 2021

Thanks for the quick fix!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants