Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): Shrink GraphQL nodes count on 50x errors #8394

Merged

Conversation

zharinov
Copy link
Collaborator

Changes:

  • Check for statusCode of exception
  • Retry query if it's 50x, shrinking queried items count by two
  • Give up if count <= 10

Context:

Closes #8098

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Unit tests + ran on a real repository

I've made dry-run against fork of Renovate repo.
The count of HTTP queries is same for this branch and for master.
Not sure if I can test it with real 500 errors 馃檭

@rarkins rarkins enabled auto-merge (squash) February 5, 2021 09:47
@rarkins rarkins merged commit 27a494f into renovatebot:master Feb 6, 2021
@renovate-release
Copy link
Collaborator

馃帀 This PR is included in version 24.41.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamically reduce pagination size when getOpenPrs() fails
5 participants