Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pip_setup): Allow setup.py to import from its own package #8417

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

hisener
Copy link
Contributor

@hisener hisener commented Jan 25, 2021

Changes:

Allow setup.py to import modules from the same package, again. This issue is re-introduced in #8320.

Context:

Closes #8415.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Unit tests + ran on a real repository

Run Renovate against https://github.com/hisener/renovate-tests/tree/master/gh-8415.

I also have a WIP branch for tests, see PicnicSupermarket/renovate@hsener/gh-8415...PicnicSupermarket:hsener/gh-8415-tests.

@rarkins rarkins merged commit 2e2b330 into renovatebot:master Jan 25, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hisener hisener deleted the hsener/gh-8415 branch January 26, 2021 06:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup.py parser unable to import files from its own package
3 participants