Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(composer): custom gitlab host auth #8612

Merged
merged 22 commits into from
May 6, 2021
Merged

feat(composer): custom gitlab host auth #8612

merged 22 commits into from
May 6, 2021

Conversation

cjose3
Copy link
Contributor

@cjose3 cjose3 commented Feb 9, 2021

Changes:

Use the hostName property from the gitlab host rules to build the variable COMPOSER_AUTH

Context:

This will allow renovate to update composer dependencies on a self hosted gitlab instance.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@cjose3 cjose3 changed the title Generate the env variable COMPOSER_AUTH using the gitlab host… feat: Generate the env variable COMPOSER_AUTH using the gitlab host… Feb 11, 2021
viceice
viceice previously approved these changes Feb 11, 2021
View reviewed changes
@viceice
Copy link
Member

viceice commented Feb 11, 2021

Please do some real tests

@rarkins rarkins marked this pull request as draft February 13, 2021 07:01
rarkins
rarkins requested changes Mar 8, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@cjose3 cjose3 marked this pull request as ready for review April 9, 2021 12:30
viceice
viceice previously approved these changes Apr 9, 2021
View reviewed changes
@viceice viceice requested a review from rarkins April 9, 2021 14:25
@rarkins rarkins enabled auto-merge (squash) April 9, 2021 15:03
rarkins
rarkins reviewed Apr 9, 2021
View reviewed changes
lib/manager/composer/artifacts.ts Outdated Show resolved Hide resolved
lib/manager/composer/artifacts.ts Outdated Show resolved Hide resolved
@cjose3
feat: Composer auth for all gitlab host rules
ac0e929 
Generates the COMPOSER_AUTH env variable for all gitlab host rules
auto-merge was automatically disabled April 27, 2021 14:27

Head branch was pushed to by a user without write access

@cjose3
Copy link
Contributor Author

cjose3 commented Apr 27, 2021

Please do some real tests

I've done some real test and it works as expected :)

@rarkins rarkins changed the title feat: Generate the env variable COMPOSER_AUTH using the gitlab host… feat(composer): custom gitlab host auth May 6, 2021
@rarkins rarkins merged commit e49213a into renovatebot:main May 6, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cjose3 @CLAassistant @viceice @renovate-release @rarkins