Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(poetry): support rangeStrategy=update-lockfile #8672

Merged
merged 20 commits into from Feb 15, 2021
Merged

feat(poetry): support rangeStrategy=update-lockfile #8672

merged 20 commits into from Feb 15, 2021

Conversation

orf
Copy link
Contributor

@orf orf commented Feb 12, 2021

Changes:

WIP: see #8671

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice marked this pull request as draft February 12, 2021 22:45
@orf
Copy link
Contributor Author

orf commented Feb 14, 2021

I've made the initial changes and it correctly resolves the lockVersion:

 "deps": [
               {
                 "depName": "boto3",
                 "depType": "dependencies",
                 "currentValue": "*",
                 "managerData": {"nestedVersion": false},
                 "datasource": "pypi",
                 "lockedVersion": "1.17.5",
                 "versioning": "poetry",
                 "depIndex": 0,
                 "updates": [],
                 "warnings": [],
                 "fixedVersion": "1.17.5",
                 "sourceUrl": "https://github.com/boto/boto3"
               }

However it's not picking up that there are any updates (1.17.5 is not the latest version of boto3). I'm using this test project if it helps.

Any idea @rarkins?

Edit: Setting currentValue to the lockfile version correctly picks up the update. I'll keep digging 🤔

@orf
Copy link
Contributor Author

orf commented Feb 14, 2021

Ahh. Silly me, I needed to set the range strategy to update-lockfile. It works now, I'll clean up and add some specific tests.

lib/manager/poetry/extract.ts Outdated Show resolved Hide resolved
@orf orf changed the title WIP: Support wildcard poetry wildcards WIP: Feat: Support wildcard poetry wildcards Feb 14, 2021
@orf orf changed the title WIP: Feat: Support wildcard poetry wildcards feat: Support wildcard poetry wildcards Feb 14, 2021
@orf orf marked this pull request as ready for review February 14, 2021 14:45
lib/manager/poetry/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/manager/poetry/extract.ts Outdated Show resolved Hide resolved
lib/manager/poetry/extract.spec.ts Show resolved Hide resolved
@viceice viceice requested a review from rarkins February 15, 2021 08:51
@rarkins rarkins changed the title feat: Support wildcard poetry wildcards feat(poetry): support rangeStrategy=update-lockfile Feb 15, 2021
@rarkins rarkins merged commit 88b19ef into renovatebot:master Feb 15, 2021
@rarkins
Copy link
Collaborator

rarkins commented Feb 15, 2021

Thanks @orf

Feel free to add yourself to the contributors list in package.json anytime too

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.50.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants