Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): handle null #8861

Merged
merged 2 commits into from
Feb 25, 2021
Merged

fix(go): handle null #8861

merged 2 commits into from
Feb 25, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Feb 25, 2021

Changes:

Check getDatasource result for null. Test doesn't fail before because datasource has catched the error.

Context:

#8859

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins February 25, 2021 13:43
@viceice viceice marked this pull request as draft February 25, 2021 13:46
@viceice viceice marked this pull request as ready for review February 25, 2021 13:51
@rarkins rarkins enabled auto-merge (squash) February 25, 2021 14:05
@rarkins rarkins merged commit fd276e4 into master Feb 25, 2021
@rarkins rarkins deleted the fix/go-null-ref branch February 25, 2021 14:06
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.64.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants