feat(go): support self hosted go modules in gitlab #8876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidgwcurve Your latest commit includes changes to |
rarkins
requested changes
Feb 26, 2021
davidgwcurve
force-pushed
the
feat/8859-support-self-hosted-go-modules-gitlab
branch
from
af37999
to
457d127
Compare
davidgwcurve
commented
Mar 1, 2021
| @@ -216,19 +254,19 @@ describe('datasource/go', () => { | |||
| httpMock | |||
| .scope('https://some.unknown.website/') | |||
| .get('/example/module?go-get=1') | |||
| .reply(404); | |||
| .reply(200); | |||
There was a problem hiding this comment.
there is a test that checks for a 404 returned from the specified URL already, this test should actually be checking that the call was successful but the code doesn't know how to handle the dependency (i.e. not github/gitlab.com/not a gitlab hostRules)
|
@rarkins I've added unit tests now and ran on our own repository, it works as expected. |
rarkins
approved these changes
Mar 1, 2021
|
🎉 This PR is included in version 24.70.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes issue #8859, #8859.
Also fixes the same logic in the changelog functionality, as after this issue was resolved I got 404's.
Context:
Closes #8859
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: