Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pypi): ensure trailing slash for simple API endpoints #8879

Merged
merged 1 commit into from Feb 26, 2021

Conversation

nejch
Copy link
Contributor

@nejch nejch commented Feb 25, 2021

Changes:

Makes the pypi lookup URL PEP-compliant with a trailing slash. Closes #8817

Context:

Related to Artifactory pypi redirects to http when no trailing slash is present. Possibly makes @dlouzan a very happy man.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@dlouzan
Copy link

dlouzan commented Feb 26, 2021

@dlouzan is happy 😁

You are awesome @nejch

@rarkins rarkins merged commit ecceadd into renovatebot:master Feb 26, 2021
@nejch nejch deleted the fix/pypi-simple-trailing-slash branch February 26, 2021 10:11
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.64.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPi Simple endpoint end slash handling
5 participants