Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only add / for lookup, not for returned registry #8888

Merged
merged 3 commits into from
Feb 28, 2021

Conversation

candrews
Copy link
Contributor

@candrews candrews commented Feb 26, 2021

Changes:

When checking to see if lookupName starts with the registry, append a / (if not already present) to the registry.
Do not append the / when returning the registry.

Note that the registry URL cannot end in a / as the / is appended to it each time it's used. For example, see

const apiCheckUrl = `${registry}/v2/`;

Context:

Fixes #8649

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2021

CLA assistant check
All committers have signed the CLA.

@candrews candrews changed the title Only add / for lookup, not for returned registry fix: Only add / for lookup, not for returned registry Feb 26, 2021
When checking to see if lookupName starts with the registry, append a / (if not already present) to the registry.
Do not append the / when returning the registry.
@rarkins rarkins enabled auto-merge (squash) February 28, 2021 05:55
@rarkins rarkins merged commit e136cd4 into renovatebot:master Feb 28, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.67.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm-values: Not working with self-hosted container registry
4 participants