fix(npm): Fix replace strategy edge-case for carets

[renovate-testing]

Changes:

Re-implement new value update logic. It's more verbose, but it backward-compatible with current behavior while fixing its edge-cases.

Context:

Closes #4762

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added unit tests, or
• No new tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[viceice]

@zharinov can you use your normal account for future pr's. 😏

[renovate-testing]

Sorry, I'm waiting for GitHub support addressing my issue with it

[viceice]

🙈😅👍

[rarkins]

These shouldn't really happen with replace though, should they?

[zharinov]

Fixed, now it remains ^2.3.4

[rarkins]

Not sure about this one?

[zharinov]

Well, it seems sometimes downgrades are desirable

[zharinov]

expect(
  poetry.getNewValue({
    currentValue: '^1.0.0',
    rangeStrategy: 'replace',
    currentVersion: '1.0.0',
    newVersion: '1.0.7',
  })
).toEqual('^1.0.7');

Do we really need upgrade to ^1.0.7 here? If I understand it right, replace strategy should return new ranges with new versions and shouldn't just shrink old ranges.

[rarkins]

expect(
  poetry.getNewValue({
    currentValue: '^1.0.0',
    rangeStrategy: 'replace',
    currentVersion: '1.0.0',
    newVersion: '1.0.7',
  })
).toEqual('^1.0.7');

Do we really need upgrade to ^1.0.7 here? If I understand it right, replace strategy should return new ranges with new versions and shouldn't just shrink old ranges.

Agreed, it should return the existing range of ^1.0.0.

[renovate-release]

🎉 This PR is included in version 24.91.1 🎉

The release is available on:

• GitHub release
• 24.91.1

Your semantic-release bot 📦🚀