Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor extractPackageFile to use js-yaml #9115

Closed
HonkingGoose opened this issue Mar 13, 2021 · 4 comments · Fixed by #14879
Closed

refactor extractPackageFile to use js-yaml #9115

HonkingGoose opened this issue Mar 13, 2021 · 4 comments · Fixed by #14879
Assignees
@viceice
Labels
manager:gitlabci GitLab CI config files priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Mar 13, 2021 •
edited

What would you like Renovate to be able to do?

From @viceice:

@HonkingGoose Please open a new issue:

Refactor extractPackageFile to use js-yaml and reuse already parsed object from extractAllPackageFiles.
So we should extract a new function parseDoc to be reused by both extract functions.

Did you already have any implementation ideas?

If we're going to be using js-yaml here, might be a good idea to migrate from js-yaml v3 to v4 first (see issue #8234)? That way you're doing the refactoring on top of up-to-date packages.
@HonkingGoose HonkingGoose added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code and removed priority-5-triage type:feature Feature (new functionality) labels Mar 13, 2021
@HonkingGoose HonkingGoose mentioned this issue Mar 13, 2021
Merged
6 tasks
@HonkingGoose HonkingGoose added status:ready status:blocked Issue is blocked by another issue or external requirement and removed status:requirements Full requirements are not yet known, so implementation should not be started status:ready labels Apr 22, 2021
@HonkingGoose

This comment has been minimized.

Sign in to view
@HonkingGoose
Copy link
Collaborator Author

The Renovate code wizards can do the refactoring now, as we have updated js-yaml to version 4.

@HonkingGoose HonkingGoose added status:ready and removed status:blocked Issue is blocked by another issue or external requirement labels Jul 23, 2021
@viceice
Copy link
Member

viceice commented Jul 24, 2021

@HonkingGoose do you remember to which manager this is applying? 🤔

@HonkingGoose
Copy link
Collaborator Author

HonkingGoose commented Jul 24, 2021 •
edited

@viceice I think you meant for this to apply to lib/manager/gitlabci/extract.ts, at least that's where you put the original comment: #8810 (comment)

@viceice viceice added the manager:gitlabci GitLab CI config files label Jul 24, 2021
@viceice viceice mentioned this issue Apr 12, 2023
Merged
6 tasks
@viceice viceice closed this as completed Apr 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@viceice viceice

Labels
manager:gitlabci GitLab CI config files priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(gitlabci): used yaml parsing hasanwhitesource/renovate
2 participants
@viceice @HonkingGoose