Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: RENOVATE_X_HARD_EXIT #9152

Merged
merged 4 commits into from Mar 16, 2021
Merged

feat: RENOVATE_X_HARD_EXIT #9152

merged 4 commits into from Mar 16, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Mar 16, 2021

Changes:

Adds an experimental env RENOVATE_X_HARD_EXIT which performs a process.exit() if set.

Context:

Workaround for ECR problems in #8660.

Not sure where/how we should document this? We have some other similar env variables too, but this is the first time I am using the RENOVATE_X_ naming convention. The idea is that these experimental options are not otherwise exposed to config or polluting our docs, and hopefully each will go away over time or be promoted to a first-class option if necessary. However should we add a new "experimental environment options" section or page in our docs?

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins mentioned this pull request Mar 16, 2021
Closed
5 tasks
viceice
viceice reviewed Mar 16, 2021
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small thing.

lib/renovate.ts Show resolved Hide resolved
@viceice
Copy link
Member

viceice commented Mar 16, 2021

Yeah, maybe adding an experimental docs page for this, and warn that those can changed any time with any release

viceice
viceice previously approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we should change the other RENOVATE_EXPERIMENTAL_** too (with migration and warning)

@rarkins
Copy link
Collaborator Author

rarkins commented Mar 16, 2021

I'm going to document the others in a commit to master first and then add this one to the docs once I've merged it into this branch. Won't rename right away.

@rarkins rarkins mentioned this pull request Mar 16, 2021
Merged
6 tasks
@rarkins
Copy link
Collaborator Author

rarkins commented Mar 16, 2021

Blocked by #9156

@rarkins rarkins marked this pull request as draft March 16, 2021 08:47
HonkingGoose
HonkingGoose reviewed Mar 16, 2021
View reviewed changes
docs/usage/self-hosted-experimental.md

## RENOVATE_X_HARD_EXIT

If set to any value, Renovate will use a "hard" `process.exit()` once all work is done, even if a sub-process is otherwise delaying Node.js from exiting.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the time you need to use a specific number/string/boolean to get things configured properly.

Are you sure literally any value will work to enable RENOVATE_X_HARD_EXIT?
I think it's clearer to say: "Set to x", where x is a specific value.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any value will do - true, yes, y, no, never, HonkingGoose. Basically it just needs to be "set"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, we can keep the text as-is then. 😄

@rarkins rarkins marked this pull request as ready for review March 16, 2021 12:31
@rarkins rarkins changed the title fix: RENOVATE_X_HARD_EXIT feat: RENOVATE_X_HARD_EXIT Mar 16, 2021
@rarkins rarkins enabled auto-merge (squash) March 16, 2021 12:32
@rarkins rarkins merged commit fc2e48d into master Mar 16, 2021
@rarkins rarkins deleted the fix/8660-ecr-hard-exit branch March 16, 2021 12:34
@HonkingGoose HonkingGoose mentioned this pull request Mar 16, 2021
Merged
6 tasks
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.87.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
rarkins added a commit that referenced this pull request Mar 20, 2021
@rarkins
Squashed commit of the following:
17de931 
commit 355aefc
Author: Rhys Arkins <rhys@arkins.net>
Date:   Sat Mar 20 07:52:03 2021 +0100

    refactor: npm managerData

commit 905067a
Author: Rhys Arkins <rhys@arkins.net>
Date:   Sat Mar 20 07:26:00 2021 +0100

    refactor: maven managerData

commit 3751467
Author: Rhys Arkins <rhys@arkins.net>
Date:   Sat Mar 20 07:23:18 2021 +0100

    refactor: composer managerData

commit eb1f645
Author: Rhys Arkins <rhys@arkins.net>
Date:   Fri Mar 19 22:31:01 2021 +0100

    fix(npm): allow npm constraint install to fail

commit 38331a7
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Fri Mar 19 18:06:53 2021 +0000

    chore(deps): update codecov/codecov-action action to v1.3.1 (#9223)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 7a9d93a
Author: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Date:   Fri Mar 19 16:54:13 2021 +0100

    chore: bump operations-per-run for stale action (#9222)

commit 1185a46
Author: Rhys Arkins <rhys@arkins.net>
Date:   Fri Mar 19 16:18:45 2021 +0100

    refactor: CACHE_REVISION

commit b63e035
Author: Rhys Arkins <rhys@arkins.net>
Date:   Fri Mar 19 16:10:58 2021 +0100

    refactor: better lock dir renaming

commit adc2f24
Author: Rhys Arkins <rhys@arkins.net>
Date:   Fri Mar 19 15:58:24 2021 +0100

    refactor: lernaJsonFile into managerData

commit 3d3cc74
Author: Rhys Arkins <rhys@arkins.net>
Date:   Fri Mar 19 15:33:23 2021 +0100

    refactor: lernaDir -> lernaJsonFile

commit 19e16ff
Author: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Date:   Fri Mar 19 12:20:31 2021 +0100

    chore: redirect docs problems to discussion (#9210)

commit b67c54e
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Fri Mar 19 00:27:36 2021 +0000

    build(deps): update dependency semantic-release to v17.4.2 (#9217)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 238b52a
Author: Rhys Arkins <rhys@arkins.net>
Date:   Thu Mar 18 16:34:53 2021 +0100

    refactor(npm): don’t write npmrc/yarnrc to root always (#9211)

commit e035722
Author: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Date:   Thu Mar 18 15:24:51 2021 +0100

    docs: improve requiredStatusChecks documentation (#9208)

commit cf98e65
Author: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Date:   Thu Mar 18 14:06:56 2021 +0100

    docs: capitalize proper noun Docker (#9197)

commit 669b9a6
Author: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Date:   Thu Mar 18 13:46:10 2021 +0100

    docs: capitalize proper noun Renovate (#9199)

commit 93a36f7
Author: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Date:   Thu Mar 18 13:45:50 2021 +0100

    docs: capitalize proper noun GitHub (#9198)

commit dc5f198
Author: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Date:   Thu Mar 18 13:45:21 2021 +0100

    docs: capitalize proper noun Git (#9196)

commit 587f50e
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Mar 18 00:22:26 2021 +0000

    chore(deps): update dependency type-fest to v0.21.3 (#9181)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 213d39f
Author: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Date:   Wed Mar 17 23:12:52 2021 +0100

    docs: capitalize proper noun Unicode, fix punctuation (#9186)

commit 3dfac42
Author: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Date:   Wed Mar 17 22:51:46 2021 +0100

    docs: set unicodeEmoji to false if using MySQL/MariaDB on BitBucket Server (#9185)

commit fc82122
Author: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Date:   Wed Mar 17 22:34:54 2021 +0100

    chore: improve reproduction:needed message (#9183)

commit 2819d4f
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Mar 17 18:26:27 2021 +0000

    chore(deps): update dependency jest-silent-reporter to v0.5.0 (#9180)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit bca8931
Author: Rhys Arkins <rhys@arkins.net>
Date:   Wed Mar 17 14:40:50 2021 +0100

    fix(npm): datasource improvements (#9178)

commit 58daaab
Author: Rhys Arkins <rhys@arkins.net>
Date:   Wed Mar 17 13:34:47 2021 +0100

    feat(internal): return registryUrl from datasources (#9177)

    Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

commit 3be8402
Author: Rhys Arkins <rhys@arkins.net>
Date:   Wed Mar 17 12:16:04 2021 +0100

    test: more maven snapshots

commit f0dede3
Author: Rhys Arkins <rhys@arkins.net>
Date:   Wed Mar 17 12:10:18 2021 +0100

    test: maven snapshots

commit 898cbd5
Author: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Date:   Wed Mar 17 09:55:53 2021 +0100

    chore: create stale action to close reproduction:needed bugs (#9165)

    Co-authored-by: Rhys Arkins <rhys@arkins.net>

commit bcc3f0e
Author: Shayne Holmes <github.snth@xoxy.net>
Date:   Tue Mar 16 22:01:34 2021 -0700

    feat(go): Pass GONOPROXY when updating artifacts (#9169)

    GONOPROXY [defaults](https://golang.org/ref/mod#environment-variables)
    to GOPRIVATE, but some callers want to set it explicitly to something
    different. Pass it when caling `go get`.

    Co-authored-by: Jamie Magee <JamieMagee@users.noreply.github.com>

commit 910e44a
Author: Rhys Arkins <rhys@arkins.net>
Date:   Tue Mar 16 21:40:07 2021 +0100

    chore: fix docs lint

commit 95ce900
Author: Rhys Arkins <rhys@arkins.net>
Date:   Tue Mar 16 19:25:03 2021 +0100

    refactor: npmId

commit 668c879
Author: Michael Kriese <michael.kriese@visualon.de>
Date:   Tue Mar 16 19:14:52 2021 +0100

    fix(gitlabci): gracefully handle errors (#9163)

    * fix(gitlabci): gracefully handle errors

    * fix: remove debugging

    * Update lib/manager/gitlabci/utils.ts

    Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

    * Apply suggestions from code review

    Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

    Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

commit 295d5ab
Author: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Date:   Tue Mar 16 16:23:06 2021 +0100

    docs: improve self-hosted experimental environment variables documentation (#9160)

commit fc2e48d
Author: Rhys Arkins <rhys@arkins.net>
Date:   Tue Mar 16 13:34:43 2021 +0100

    feat: RENOVATE_X_HARD_EXIT (#9152)

    Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

commit f8580a1
Author: Michael Kriese <michael.kriese@visualon.de>
Date:   Tue Mar 16 11:10:18 2021 +0100

    feat(gitea): filter archived autodiscover repos (#9153)

commit ace4227
Author: Rhys Arkins <rhys@arkins.net>
Date:   Tue Mar 16 10:16:59 2021 +0100

    docs: Self-hosted experimental (#9156)

commit 6a2345d
Author: Michael Kriese <michael.kriese@visualon.de>
Date:   Tue Mar 16 08:59:00 2021 +0100

    fix: add additional source url overrides (#9151)

commit 0747c9a
Author: Rhys Arkins <rhys@arkins.net>
Date:   Mon Mar 15 18:13:58 2021 +0100

    fix: CACHE_REVISION=4

    Git submodules extraction has changed.

commit 40a59cc
Author: Michael Kriese <michael.kriese@visualon.de>
Date:   Mon Mar 15 14:23:38 2021 +0100

    feat: use short renovate image names (#9133)

    Co-authored-by: Rhys Arkins <rhys@arkins.net>

commit f1a4102
Author: Rhys Arkins <rhys@arkins.net>
Date:   Mon Mar 15 13:56:23 2021 +0100

    refactor: customRegistrySupport (#9142)

commit 6ebe8ba
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Mar 15 11:49:07 2021 +0100

    build(deps): update dependency @renovatebot/ruby-semver to v1 (#9140)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 9c48616
Author: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Date:   Mon Mar 15 09:39:52 2021 +0100

    chore: capitalize noun Git in comment (#9137)

commit 0149e76
Author: Michael Kriese <michael.kriese@visualon.de>
Date:   Mon Mar 15 08:49:56 2021 +0100

    feat(mix): migrate to modern docker handling (#9132)

commit e0dfc81
Author: Henrik Karlsson <hk.henrik@gmail.com>
Date:   Mon Mar 15 07:29:52 2021 +0100

    chore: Install a newer version of git in the vscode devcontainer to fix failing tests (#9131)

commit a45c5f3
Author: Rhys Arkins <rhys@arkins.net>
Date:   Mon Mar 15 07:11:46 2021 +0100

    refactor: remove git-submodules datasource (#9128)

commit 0f7875e
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Mar 15 02:52:31 2021 +0000

    chore(deps): update dependency nock to v13.0.11 (#9129)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 06c246e
Author: Rhys Arkins <rhys@arkins.net>
Date:   Sun Mar 14 20:58:47 2021 +0100

    feat(internal): fixedRegistries (#9124)

commit 084f9dc
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Sun Mar 14 14:42:54 2021 +0000

    chore(deps): update dependency @types/eslint to v7.2.7 (#9125)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit ea0bcdd
Author: renovate-testing <77205328+renovate-testing@users.noreply.github.com>
Date:   Sun Mar 14 11:27:40 2021 +0300

    feat(git): Specify additional git authors to ignore (#9082)

commit 717e4e6
Author: Rhys Arkins <rhys@arkins.net>
Date:   Sun Mar 14 07:33:53 2021 +0100

    fix: stabilityStatus non-null check

commit 926f23f
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Sat Mar 13 23:32:55 2021 +0000

    chore(deps): update dependency @types/luxon to v1.26.2 (#9121)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose left review comments

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rarkins @viceice @renovate-release @HonkingGoose